Skip to content

Use OpaqueTypeKey in query response #111450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2023
Merged

Use OpaqueTypeKey in query response #111450

merged 1 commit into from
May 20, 2023

Conversation

@compiler-errors
Copy link
Member

Makes it a bit clearer that at least one of the types being returned from a canonical query is an opaque.

@rustbot
Copy link
Collaborator

rustbot commented May 10, 2023

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels May 10, 2023
@compiler-errors
Copy link
Member Author

r? compiler

@rustbot rustbot assigned wesleywiser and unassigned TaKO8Ki May 14, 2023
@compiler-errors
Copy link
Member Author

r? @oli-obk

@rustbot rustbot assigned oli-obk and unassigned wesleywiser May 19, 2023
@oli-obk
Copy link
Contributor

oli-obk commented May 20, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 20, 2023

📌 Commit 6f27876 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2023
@GuillaumeGomez GuillaumeGomez mentioned this pull request May 20, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 20, 2023
@bors
Auto merge of rust-lang#111798 - GuillaumeGomez:rollup-t3bus8o, r=Gui…
6bacf5a 
…llaumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#111450 (Use `OpaqueTypeKey` in query response)
 - rust-lang#111726 (Migrate GUI colors test to original CSS color format)
 - rust-lang#111746 (Merge some query impl modules into one)
 - rust-lang#111765 (Migrate GUI colors test to original CSS color format)
 - rust-lang#111771 (add `--remote-time` flag to curl for bootstrap)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit de07424 into rust-lang:master May 20, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 20, 2023
@compiler-errors compiler-errors deleted the opaque-ty-key branch August 11, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oli-obk oli-obk

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

1.71.0

Development

Successfully merging this pull request may close these issues.

6 participants

@compiler-errors @rustbot @oli-obk @bors @wesleywiser @TaKO8Ki