-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update browser-ui-test version to 0.16.0 #111459
Conversation
store-property: (index_sidebar_width, ".sidebar .location a", "clientWidth") | ||
store-property: (index_sidebar_height, ".sidebar .location a", "clientHeight") | ||
store-property: (index_sidebar_x, ".sidebar .location a", "offsetTop") | ||
store-property: (index_sidebar_y, ".sidebar .location a", "offsetLeft") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, past me. 🤦♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, nice job to past me as well for not seeing it when reviewing. 😛
@bors r+ rollup |
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
…est, r=notriddle Update browser-ui-test version to 0.16.0 This new version brings one major improvement: it allows to use the original color format in checks (I plan to slowly continue converting colors back to their "original" format, ie the one used in CSS). It also provides some improvements in some commands API. r? `@notriddle`
…est, r=notriddle Update browser-ui-test version to 0.16.0 This new version brings one major improvement: it allows to use the original color format in checks (I plan to slowly continue converting colors back to their "original" format, ie the one used in CSS). It also provides some improvements in some commands API. r? ``@notriddle``
…est, r=notriddle Update browser-ui-test version to 0.16.0 This new version brings one major improvement: it allows to use the original color format in checks (I plan to slowly continue converting colors back to their "original" format, ie the one used in CSS). It also provides some improvements in some commands API. r? ```@notriddle```
…est, r=notriddle Update browser-ui-test version to 0.16.0 This new version brings one major improvement: it allows to use the original color format in checks (I plan to slowly continue converting colors back to their "original" format, ie the one used in CSS). It also provides some improvements in some commands API. r? ````@notriddle````
…mpiler-errors Rollup of 7 pull requests Successful merges: - rust-lang#106038 (use implied bounds when checking opaque types) - rust-lang#111366 (Make `NonUseContext::AscribeUserTy` carry `ty::Variance`) - rust-lang#111375 (CFI: Fix SIGILL reached via trait objects) - rust-lang#111439 (Fix backtrace normalization in ice-bug-report-url.rs) - rust-lang#111444 (Only warn single-use lifetime when the binders match.) - rust-lang#111459 (Update browser-ui-test version to 0.16.0) - rust-lang#111460 (Improve suggestion for `self: Box<self>`) Failed merges: - rust-lang#110454 (Require impl Trait in associated types to appear in method signatures) r? `@ghost` `@rustbot` modify labels: rollup
…lor-34, r=notriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang#111459. This test needed more cleanup: first I removed duplication by using a function, then I merge similar rules which had the same values. r? `@notriddle`
…r-35, r=notriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang#111459. r? `@notriddle`
…otriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang/rust#111459. r? `@notriddle`
…lor-36, r=notriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang#111459. r? `@notriddle`
…r-37, r=notriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang#111459. r? `@notriddle`
…otriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang/rust#111459. r? `@notriddle`
…lor-38, r=notriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang#111459. r? `@notriddle`
…r-39, r=notriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang#111459. r? `@notriddle`
…r-40, r=notriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang#111459. r? `@notriddle`
…otriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang/rust#111459. r? `@notriddle`
…otriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang/rust#111459. r? `@notriddle`
…lor-41, r=notriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang#111459. r? `@notriddle`
Rollup merge of rust-lang#115890 - GuillaumeGomez:migrate-gui-test-color-41, r=notriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang#111459. r? `@notriddle`
…lor-42, r=notriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang#111459. And with this one I'm finally done with this migration. r? `@notriddle`
…lor-42, r=notriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang#111459. And with this one I'm finally done with this migration. r? ``@notriddle``
Rollup merge of rust-lang#116106 - GuillaumeGomez:migrate-gui-test-color-42, r=notriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang#111459. And with this one I'm finally done with this migration. r? ``@notriddle``
…otriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang/rust#111459. r? `@notriddle`
…otriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang/rust#111459. r? `@notriddle`
This new version brings one major improvement: it allows to use the original color format in checks (I plan to slowly continue converting colors back to their "original" format, ie the one used in CSS).
It also provides some improvements in some commands API.
r? @notriddle