Skip to content

better diagnostics for impl<..> impl Trait for Type #111477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2023
Merged

better diagnostics for impl<..> impl Trait for Type #111477

merged 1 commit into from
May 14, 2023

Conversation

y21
Copy link
Member

@y21 y21 commented May 11, 2023

Fixes #109963

@rustbot
Copy link
Collaborator

rustbot commented May 11, 2023

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 11, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors
Copy link
Member

Please squash this into one commit. Then I can approve, thanks

@y21 y21 force-pushed the extra-impl-in-trait-impl branch from d055fb2 to 7fe8334 Compare May 13, 2023 08:52
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 13, 2023

📌 Commit 7fe8334 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 13, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request May 14, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 14, 2023
@bors
Auto merge of rust-lang#111552 - matthiaskrgr:rollup-4nidoti, r=matth…
0a0e045 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#111463 (Better diagnostics for `env!` where variable contains escape)
 - rust-lang#111477 (better diagnostics for `impl<..> impl Trait for Type`)
 - rust-lang#111534 (rustdoc-json: Add tests for `#![feature(inherent_associated_types)]`)
 - rust-lang#111549 ([rustdoc] Convert more GUI tests colors to their original format)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d7f7425 into rust-lang:master May 14, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.

Want better error for impl<some generics> impl Trait for Type {...}
6 participants
@y21 @rustbot @rust-log-analyzer @compiler-errors @bors @jackh726