-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct comment on privately uninhabited pattern. #111951
Conversation
Some changes might have occurred in exhaustiveness checking cc @Nadrieril |
@@ -51,6 +51,10 @@ fn empty_foreign_enum(x: empty::EmptyForeignEnum) { | |||
} | |||
} | |||
|
|||
fn empty_foreign_enum_private(x: Option<empty::SecretlyUninhabitedForeignStruct>) { | |||
let None = x; //~ ERROR refutable pattern in local binding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the expected notes here too?
Oh that forces you to annotate all the NOTEs that's annoying. I'm happy with or without then. r=me with whichever choice you prefer |
I wrote them, now it's too late 😄 |
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#111384 (Fix linking Mac Catalyst by including LC_BUILD_VERSION in object files) - rust-lang#111899 (CGU cleanups) - rust-lang#111940 (Clarify safety concern of `io::Read::read` is only relevant in unsafe code) - rust-lang#111947 (Add test for RPIT defined with different hidden types with different substs) - rust-lang#111951 (Correct comment on privately uninhabited pattern.) Failed merges: - rust-lang#111954 (improve error message for calling a method on a raw pointer with an unknown pointee) r? `@ghost` `@rustbot` modify labels: rollup
Follow-up to #111624 (comment)
r? @Nadrieril