-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a single codegen unit for fully optimized builds. #111978
Conversation
This gives fantastic results for me locally, with walltime improvements up to 6%, and max-rss improvements of up to 8%. @bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit ed1fa3f with merge defd35309e7c427b71bd35de82847fe50c8f138c... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is really exciting!
rust_codegen_units = Some(1) | ||
} | ||
if fully_optimized && rust_codegen_units_std.is_none() { | ||
rust_codegen_units_std = Some(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a pre-existing bug and doesn't affect your pr, but i think this should default to rust_codegen_units
if it's set, not have an independent default, like how debug-assertions-std
works
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
We had been experimenting with this in #107651, where we've encountered the same CI issue as this PR (likely BOLT's llvm/llvm-project#59174). We'll keep working on this, and circumventing the issue in that other PR. |
Yes, let's continue this work in #107651. |
r? @ghost