Skip to content

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented May 28, 2023

Various CI experiments for try/dist builds.

r? @ghost

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 28, 2023
@Kobzol
Copy link
Member Author

Kobzol commented May 28, 2023

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 28, 2023
@bors
Copy link
Collaborator

bors commented May 28, 2023

⌛ Trying commit c42e33cf36e728937b9e7d9bbb16c17d0b364e23 with merge c60ecf63ab7a2a0a260b0a8ee02adff4f4dbfe87...

@bors
Copy link
Collaborator

bors commented May 28, 2023

☀️ Try build successful - checks-actions
Build commit: c60ecf63ab7a2a0a260b0a8ee02adff4f4dbfe87 (c60ecf63ab7a2a0a260b0a8ee02adff4f4dbfe87)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c60ecf63ab7a2a0a260b0a8ee02adff4f4dbfe87): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.3% [0.3%, 0.3%] 2
Regressions ❌
(secondary)
0.3% [0.3%, 0.3%] 2
Improvements ✅
(primary)
-0.3% [-0.3%, -0.3%] 1
Improvements ✅
(secondary)
-0.4% [-0.7%, -0.2%] 9
All ❌✅ (primary) 0.1% [-0.3%, 0.3%] 3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.4% [3.4%, 3.4%] 1
Regressions ❌
(secondary)
1.8% [1.8%, 1.8%] 1
Improvements ✅
(primary)
-3.5% [-3.5%, -3.5%] 1
Improvements ✅
(secondary)
-3.4% [-3.7%, -3.1%] 2
All ❌✅ (primary) -0.1% [-3.5%, 3.4%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.0% [-2.2%, -1.7%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 646.44s -> 646.666s (0.03%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 29, 2023
@Kobzol
Copy link
Member Author

Kobzol commented May 29, 2023

Looks like removing libcore from the profile set doesn't hurt much. Now I'll try to also completely remove rustc-perf gathering when gathering LLVM PGO profiles.

Looks like after the initial stage 2 build with an instrumented LLVM, there is already 6 GiB of profiles (after benchmarks it's usually 20 GiB). So instrumenting stage 2 build provides a lot of data! I'll try what happens if we delete the profiles.

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 29, 2023
@bors
Copy link
Collaborator

bors commented May 29, 2023

⌛ Trying commit 31c917d813e3461b6babe1220a1ac15fc66eae53 with merge 3004a6cee0725e571674b0efdefcd9b82b1e11d6...

@bors
Copy link
Collaborator

bors commented May 29, 2023

☀️ Try build successful - checks-actions
Build commit: 3004a6cee0725e571674b0efdefcd9b82b1e11d6 (3004a6cee0725e571674b0efdefcd9b82b1e11d6)

@rust-timer

This comment has been minimized.

@Kobzol
Copy link
Member Author

Kobzol commented May 29, 2023

@bors try

@bors
Copy link
Collaborator

bors commented May 29, 2023

⌛ Trying commit 042e02535bb5a95c8d6d77fc5954d762b73079e0 with merge ed48ba9307a0a1b523e3519499c3918be2dba056...

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3004a6cee0725e571674b0efdefcd9b82b1e11d6): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.2% [0.3%, 7.3%] 51
Regressions ❌
(secondary)
3.1% [0.4%, 5.9%] 24
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.2% [0.3%, 7.3%] 51

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.5% [2.5%, 2.5%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.6% [0.8%, 4.1%] 32
Regressions ❌
(secondary)
2.8% [1.8%, 3.6%] 12
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.6% [0.8%, 4.1%] 32

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 642.999s -> 642.878s (-0.02%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 29, 2023
@bors
Copy link
Collaborator

bors commented May 29, 2023

☀️ Try build successful - checks-actions
Build commit: ed48ba9307a0a1b523e3519499c3918be2dba056 (ed48ba9307a0a1b523e3519499c3918be2dba056)

@Kobzol
Copy link
Member Author

Kobzol commented May 29, 2023

@rust-timer build ed48ba9307a0a1b523e3519499c3918be2dba056

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ed48ba9307a0a1b523e3519499c3918be2dba056): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.0% [-2.0%, -0.3%] 33
Improvements ✅
(secondary)
-1.1% [-1.5%, -0.4%] 12
All ❌✅ (primary) -1.0% [-2.0%, -0.3%] 33

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.5% [2.5%, 2.5%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.8% [-2.8%, -2.8%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 642.999s -> 644.35s (0.21%)

@rustbot rustbot removed the perf-regression Performance regression. label May 29, 2023
@rust-timer
Copy link
Collaborator

@rust-timer command cannot be empty

13 similar comments
@rust-timer
Copy link
Collaborator

@rust-timer command cannot be empty

@rust-timer
Copy link
Collaborator

@rust-timer command cannot be empty

@rust-timer
Copy link
Collaborator

@rust-timer command cannot be empty

@rust-timer
Copy link
Collaborator

@rust-timer command cannot be empty

@rust-timer
Copy link
Collaborator

@rust-timer command cannot be empty

@rust-timer
Copy link
Collaborator

@rust-timer command cannot be empty

@rust-timer
Copy link
Collaborator

@rust-timer command cannot be empty

@rust-timer
Copy link
Collaborator

@rust-timer command cannot be empty

@rust-timer
Copy link
Collaborator

@rust-timer command cannot be empty

@rust-timer
Copy link
Collaborator

@rust-timer command cannot be empty

@rust-timer
Copy link
Collaborator

@rust-timer command cannot be empty

@rust-timer
Copy link
Collaborator

@rust-timer command cannot be empty

@rust-timer
Copy link
Collaborator

@rust-timer command cannot be empty

@Kobzol
Copy link
Member Author

Kobzol commented Nov 17, 2025

@rust-timer queue

1 similar comment
@Kobzol
Copy link
Member Author

Kobzol commented Nov 17, 2025

@rust-timer queue

@Kobzol
Copy link
Member Author

Kobzol commented Nov 17, 2025

@rust-timer

2 similar comments
@Kobzol
Copy link
Member Author

Kobzol commented Nov 17, 2025

@rust-timer

@Kobzol
Copy link
Member Author

Kobzol commented Nov 17, 2025

@rust-timer

@rust-timer
Copy link
Collaborator

Command cannot be empty

@Kobzol
Copy link
Member Author

Kobzol commented Nov 18, 2025

@rust-timer queue backends=foo

@rust-timer
Copy link
Collaborator

Error occurred while parsing comment: Cannot parse backends: Invalid backend: foo. Valid values are: llvm, cranelift

@Kobzol Kobzol force-pushed the pgo-omit-benchmarks branch from ed2767a to d814280 Compare November 21, 2025 15:59
@Kobzol
Copy link
Member Author

Kobzol commented Nov 21, 2025

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

This pull request is already queued and waiting for a try build to finish.

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Nov 21, 2025
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
#19 0.133 + tar xf -
#19 0.136   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
#19 0.136                                  Dload  Upload   Total   Spent    Left  Speed
#19 0.136 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (7) Failed to connect to 2001:470:142:3::b: Network is unreachable
#19 1.179 xzcat: (stdin): File format not recognized
#19 1.180 tar: This does not look like a tar archive
#19 1.180 tar: Exiting with failure status due to previous errors
#19 ERROR: process "/bin/sh -c ./build-gcc.sh && yum remove -y gcc gcc-c++" did not complete successfully: exit code: 2
------
 > importing cache manifest from ghcr.io/rust-lang/rust-ci-cache:81c439862f94e6f5bf7a795a9f80d9031da1b066f1ac56f9bb07fd59bd34adacb288009a03ff4acd9467374ddbaa95dce667dae01fc95d58efb7620103f49467:
------
------
 > [11/21] RUN ./build-gcc.sh && yum remove -y gcc gcc-c++:
0.132 + source shared.sh
curl: (7) Failed to connect to 2001:470:142:3::b: Network is unreachable
1.179 xzcat: (stdin): File format not recognized
1.180 tar: This does not look like a tar archive
1.180 tar: Exiting with failure status due to previous errors
------
Dockerfile:59
--------------------
  57 |     ENV GCC_VERSION=9.2.0
---
#18 0.097   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
#18 0.097                                  Dload  Upload   Total   Spent    Left  Speed
#18 0.097 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0curl: (7) Failed to connect to 2001:470:142:3::b: Network is unreachable
#18 1.148 xzcat: (stdin): File format not recognized
#18 1.148 tar: This does not look like a tar archive
#18 1.148 tar: Exiting with failure status due to previous errors
#18 ERROR: process "/bin/sh -c ./build-gcc.sh && yum remove -y gcc gcc-c++" did not complete successfully: exit code: 2
------
 > importing cache manifest from ghcr.io/rust-lang/rust-ci-cache:81c439862f94e6f5bf7a795a9f80d9031da1b066f1ac56f9bb07fd59bd34adacb288009a03ff4acd9467374ddbaa95dce667dae01fc95d58efb7620103f49467:
------
------
 > [11/21] RUN ./build-gcc.sh && yum remove -y gcc gcc-c++:
0.094 + source shared.sh
curl: (7) Failed to connect to 2001:470:142:3::b: Network is unreachable
1.148 xzcat: (stdin): File format not recognized
1.148 tar: This does not look like a tar archive
1.148 tar: Exiting with failure status due to previous errors
------
Dockerfile:59
--------------------
  57 |     ENV GCC_VERSION=9.2.0
---
  0     0    0     0    0     0      0      0 --:--:--  0:02:06 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:02:07 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:02:08 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:02:09 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:02:10 --:--:--     0curl: (7) Failed to connect to 2001:470:142:3::b: Network is unreachable
#16 130.4 xzcat: (stdin): File format not recognized
#16 130.4 tar: This does not look like a tar archive
#16 130.4 tar: Exiting with failure status due to previous errors
#16 ERROR: process "/bin/sh -c ./build-gcc.sh && yum remove -y gcc gcc-c++" did not complete successfully: exit code: 2
------
 > importing cache manifest from ghcr.io/rust-lang/rust-ci-cache:81c439862f94e6f5bf7a795a9f80d9031da1b066f1ac56f9bb07fd59bd34adacb288009a03ff4acd9467374ddbaa95dce667dae01fc95d58efb7620103f49467:
------
------
 > [11/21] RUN ./build-gcc.sh && yum remove -y gcc gcc-c++:
0.090 + source shared.sh
curl: (7) Failed to connect to 2001:470:142:3::b: Network is unreachable
130.4 xzcat: (stdin): File format not recognized
130.4 tar: This does not look like a tar archive
130.4 tar: Exiting with failure status due to previous errors
------
Dockerfile:59
--------------------
  57 |     ENV GCC_VERSION=9.2.0
---
#18 0.100   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
#18 0.100                                  Dload  Upload   Total   Spent    Left  Speed
#18 0.100 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0curl: (7) Failed to connect to 2001:470:142:3::b: Network is unreachable
#18 1.618 xzcat: (stdin): File format not recognized
#18 1.618 tar: This does not look like a tar archive
#18 1.618 tar: Exiting with failure status due to previous errors
#18 ERROR: process "/bin/sh -c ./build-gcc.sh && yum remove -y gcc gcc-c++" did not complete successfully: exit code: 2
------
 > importing cache manifest from ghcr.io/rust-lang/rust-ci-cache:81c439862f94e6f5bf7a795a9f80d9031da1b066f1ac56f9bb07fd59bd34adacb288009a03ff4acd9467374ddbaa95dce667dae01fc95d58efb7620103f49467:
------
------
 > [11/21] RUN ./build-gcc.sh && yum remove -y gcc gcc-c++:
0.096 + source shared.sh
curl: (7) Failed to connect to 2001:470:142:3::b: Network is unreachable
1.618 xzcat: (stdin): File format not recognized
1.618 tar: This does not look like a tar archive
1.618 tar: Exiting with failure status due to previous errors
------
Dockerfile:59
--------------------
  57 |     ENV GCC_VERSION=9.2.0
---
#16 0.104   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
#16 0.104                                  Dload  Upload   Total   Spent    Left  Speed
#16 0.104 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0curl: (7) Failed to connect to 2001:470:142:3::b: Network is unreachable
#16 1.510 xzcat: (stdin): File format not recognized
#16 1.510 tar: This does not look like a tar archive
#16 1.510 tar: Exiting with failure status due to previous errors
#16 ERROR: process "/bin/sh -c ./build-gcc.sh && yum remove -y gcc gcc-c++" did not complete successfully: exit code: 2
------
 > importing cache manifest from ghcr.io/rust-lang/rust-ci-cache:81c439862f94e6f5bf7a795a9f80d9031da1b066f1ac56f9bb07fd59bd34adacb288009a03ff4acd9467374ddbaa95dce667dae01fc95d58efb7620103f49467:
------
------
 > [11/21] RUN ./build-gcc.sh && yum remove -y gcc gcc-c++:
0.100 + source shared.sh
curl: (7) Failed to connect to 2001:470:142:3::b: Network is unreachable
1.510 xzcat: (stdin): File format not recognized
1.510 tar: This does not look like a tar archive
1.510 tar: Exiting with failure status due to previous errors
------
Dockerfile:59
--------------------
  57 |     ENV GCC_VERSION=9.2.0

@rust-bors
Copy link

rust-bors bot commented Nov 21, 2025

💔 Test for 3b44db5 failed: CI. Failed jobs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-compiletest Area: The compiletest test runner A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.