[do not merge] CI experiments #112049

Kobzol · 2023-05-28T21:07:18Z

Various CI experiments for try/dist builds.

Kobzol · 2023-05-28T21:07:27Z

bors · 2023-05-28T21:07:35Z

⌛ Trying commit c42e33cf36e728937b9e7d9bbb16c17d0b364e23 with merge c60ecf63ab7a2a0a260b0a8ee02adff4f4dbfe87...

bors · 2023-05-28T22:44:38Z

☀️ Try build successful - checks-actions
Build commit: c60ecf63ab7a2a0a260b0a8ee02adff4f4dbfe87 (c60ecf63ab7a2a0a260b0a8ee02adff4f4dbfe87)

rust-timer · 2023-05-29T03:49:49Z

Finished benchmarking commit (c60ecf63ab7a2a0a260b0a8ee02adff4f4dbfe87): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.3%, 0.3%]	2
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	2
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.3%]	1
Improvements ✅ (secondary)	-0.4%	[-0.7%, -0.2%]	9
All ❌✅ (primary)	0.1%	[-0.3%, 0.3%]	3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.4%	[3.4%, 3.4%]	1
Regressions ❌ (secondary)	1.8%	[1.8%, 1.8%]	1
Improvements ✅ (primary)	-3.5%	[-3.5%, -3.5%]	1
Improvements ✅ (secondary)	-3.4%	[-3.7%, -3.1%]	2
All ❌✅ (primary)	-0.1%	[-3.5%, 3.4%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.2%, -1.7%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 646.44s -> 646.666s (0.03%)

Kobzol · 2023-05-29T06:14:36Z

Looks like removing libcore from the profile set doesn't hurt much. Now I'll try to also completely remove rustc-perf gathering when gathering LLVM PGO profiles.

Looks like after the initial stage 2 build with an instrumented LLVM, there is already 6 GiB of profiles (after benchmarks it's usually 20 GiB). So instrumenting stage 2 build provides a lot of data! I'll try what happens if we delete the profiles.

@bors try @rust-timer queue

bors · 2023-05-29T06:14:48Z

⌛ Trying commit 31c917d813e3461b6babe1220a1ac15fc66eae53 with merge 3004a6cee0725e571674b0efdefcd9b82b1e11d6...

bors · 2023-05-29T08:17:30Z

☀️ Try build successful - checks-actions
Build commit: 3004a6cee0725e571674b0efdefcd9b82b1e11d6 (3004a6cee0725e571674b0efdefcd9b82b1e11d6)

Kobzol · 2023-05-29T08:19:19Z

@bors try

bors · 2023-05-29T08:19:28Z

⌛ Trying commit 042e02535bb5a95c8d6d77fc5954d762b73079e0 with merge ed48ba9307a0a1b523e3519499c3918be2dba056...

rust-timer · 2023-05-29T09:33:21Z

Finished benchmarking commit (3004a6cee0725e571674b0efdefcd9b82b1e11d6): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.2%	[0.3%, 7.3%]	51
Regressions ❌ (secondary)	3.1%	[0.4%, 5.9%]	24
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.2%	[0.3%, 7.3%]	51

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[2.5%, 2.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.6%	[0.8%, 4.1%]	32
Regressions ❌ (secondary)	2.8%	[1.8%, 3.6%]	12
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.6%	[0.8%, 4.1%]	32

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 642.999s -> 642.878s (-0.02%)

bors · 2023-05-29T10:34:36Z

☀️ Try build successful - checks-actions
Build commit: ed48ba9307a0a1b523e3519499c3918be2dba056 (ed48ba9307a0a1b523e3519499c3918be2dba056)

Kobzol · 2023-05-29T10:56:16Z

@rust-timer build ed48ba9307a0a1b523e3519499c3918be2dba056

rust-timer · 2023-05-29T12:33:22Z

Finished benchmarking commit (ed48ba9307a0a1b523e3519499c3918be2dba056): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.0%	[-2.0%, -0.3%]	33
Improvements ✅ (secondary)	-1.1%	[-1.5%, -0.4%]	12
All ❌✅ (primary)	-1.0%	[-2.0%, -0.3%]	33

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[2.5%, 2.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.8%	[-2.8%, -2.8%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 642.999s -> 644.35s (0.21%)

bors · 2025-05-28T08:56:26Z

☀️ Try build successful - checks-actions
Build commit: e340f09 (e340f09c5b841c39f1ff8da87490cfeb039e70dd)

Kobzol · 2025-05-28T08:57:01Z

@rustbot label -S-waiting-on-author +S-waiting-on-review

rust-timer · 2025-05-28T11:00:10Z

Finished benchmarking commit (e340f09): comparison URL.

Overall result: no relevant changes - BENCHMARK(S) FAILED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

❗ ❗ ❗ ❗ ❗
Warning ⚠️: The following benchmark(s) failed to build:

rustc

❗ ❗ ❗ ❗ ❗

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.8%, secondary -3.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.8%, 0.8%]	1
Regressions ❌ (secondary)	2.7%	[1.2%, 4.8%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-6.4%	[-8.9%, -5.0%]	7
All ❌✅ (primary)	0.8%	[0.8%, 0.8%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: missing data
Artifact size: 368.46 MiB -> 366.57 MiB (-0.51%)

Kobzol · 2025-05-29T06:54:37Z

r? @jyn514

(Just testing triagebot assignment warnings for people in users_on_vacation)

rustbot · 2025-05-29T06:54:41Z

Failed to set assignee to jyn514: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

rustbot · 2025-05-29T06:54:41Z

jyn514 is not on the review rotation at the moment.
They may take a while to respond.

Kobzol · 2025-05-29T06:57:02Z

r? @fmease

(same, testing again)

rustbot · 2025-05-29T06:57:06Z

fmease is not on the review rotation at the moment.
They may take a while to respond.

Kobzol · 2025-05-29T06:57:15Z

Ok, looks good!

r? @Kobzol

Kobzol · 2025-05-29T11:47:35Z

@bors2 ping

Kobzol · 2025-05-29T11:56:26Z

@bors2 ping

Kobzol · 2025-05-29T12:04:31Z

@bors2 ping

rust-bors · 2025-05-29T12:04:34Z

Pong 🏓!

Kobzol · 2025-05-29T12:04:49Z

@bors2 help

rust-bors · 2025-05-29T12:04:52Z

r+ [p=<priority>] [rollup=<never|iffy|maybe|always>]: Approve this PR. Optionally, you can specify <priority>, <rollup>.
r=<user> [p=<priority>]: Approve this PR on behalf of <user>. Optionally, you can specify a <priority>.
r-: Unapprove this PR
p=<priority>: Set the priority of this PR
delegate=<try|review>: Delegate permissions to the PR author
delegate+: Delegate review permissions to the PR author
delegate-: Remove any previously granted delegation
try [parent=<parent>] [jobs=<jobs>]: Start a try build. Optionally, you can specify a <parent> SHA or a list of <jobs> to run
try cancel: Cancel a running try build
rollup=<never|iffy|maybe|always>: Mark the rollup status of the PR
info: Get information about the current PR including delegation, priority, merge status, and try build status
ping: Check if the bot is alive
help: Print this help message
treeclosed-, treeopen: Open the repository tree for merging
treeclosed=<priority>: Close the tree for PRs with priority less than <priority>

Kobzol · 2025-05-29T12:27:28Z

@bors2 info

rust-bors · 2025-05-29T12:27:31Z

Not Approved
Priority: Not set

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 28, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 28, 2023

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 29, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 29, 2023

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 29, 2023

This comment has been minimized.

Sign in to view

rustbot removed the perf-regression Performance regression. label May 29, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 28, 2025

This comment has been minimized.

Sign in to view

Kobzol added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 28, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 28, 2025

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 28, 2025

Kobzol mentioned this pull request May 29, 2025

Only post suppressed assignment warning when assignment succeeds rust-lang/triagebot#2023

Merged

rustbot assigned fmease and unassigned Kobzol May 29, 2025

rustbot assigned Kobzol and unassigned fmease May 29, 2025

[do not merge] CI experiments #112049

Are you sure you want to change the base?

[do not merge] CI experiments #112049

Conversation

Kobzol commented May 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kobzol commented May 28, 2023

Uh oh!

This comment has been minimized.

bors commented May 28, 2023

Uh oh!

bors commented May 28, 2023

Uh oh!

This comment has been minimized.

rust-timer commented May 29, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Uh oh!

Kobzol commented May 29, 2023

Uh oh!

This comment has been minimized.

bors commented May 29, 2023

Uh oh!

bors commented May 29, 2023

Uh oh!

This comment has been minimized.

Kobzol commented May 29, 2023

Uh oh!

bors commented May 29, 2023

Uh oh!

rust-timer commented May 29, 2023

Overall result: ❌ regressions - ACTION NEEDED

Uh oh!

bors commented May 29, 2023

Uh oh!

Kobzol commented May 29, 2023

Uh oh!

This comment has been minimized.

rust-timer commented May 29, 2023

Overall result: ✅ improvements - no action needed

Uh oh!

bors commented May 28, 2025

Uh oh!

This comment has been minimized.

Kobzol commented May 28, 2025

Uh oh!

rust-timer commented May 28, 2025

Overall result: no relevant changes - BENCHMARK(S) FAILED

Uh oh!

Kobzol commented May 29, 2025

Uh oh!

rustbot commented May 29, 2025

Uh oh!

rustbot commented May 29, 2025

Uh oh!

Kobzol commented May 29, 2025

Uh oh!

rustbot commented May 29, 2025

Uh oh!

Kobzol commented May 29, 2025

Uh oh!

Kobzol commented May 29, 2025

Uh oh!

Kobzol commented May 29, 2025

Uh oh!

Kobzol commented May 29, 2025

Uh oh!

rust-bors bot commented May 29, 2025

Uh oh!

Kobzol commented May 29, 2025

Uh oh!

rust-bors bot commented May 29, 2025

Uh oh!

Kobzol commented May 29, 2025

Uh oh!

rust-bors bot commented May 29, 2025

Uh oh!

Uh oh!

Kobzol commented May 28, 2023 •

edited

Loading