Cache more MIR traversals

[Noratrieb]

There's an existing cache for MIR postorder traversal, which isn't used in traversal::postorder though. The first commit fixes this. The second commit adds an additional cache for preorder.

[rustbot]

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

[Noratrieb]

@bors try @rust-timer queue

[rustbot]

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

[bors]

⌛ Trying commit de9e08a with merge fea8acdd44a41604a9e344aa463ecc6b74b8c32d...

[bors]

☀️ Try build successful - checks-actions
Build commit: fea8acdd44a41604a9e344aa463ecc6b74b8c32d (fea8acdd44a41604a9e344aa463ecc6b74b8c32d)

[rust-timer]

Finished benchmarking commit (fea8acdd44a41604a9e344aa463ecc6b74b8c32d): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.2%, 1.1%]	23
Regressions ❌ (secondary)	0.9%	[0.4%, 1.2%]	9
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[0.2%, 1.1%]	23

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.3%	[0.5%, 2.9%]	7
Regressions ❌ (secondary)	2.6%	[1.2%, 4.9%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.3%	[0.5%, 2.9%]	7

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.8%	[-3.4%, -2.3%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 646.023s -> 648.346s (0.36%)

[Noratrieb]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 7fbc8d4 with merge 5d8f37a5e6b178a40e83eb040ae6522765066dba...

[bors]

☀️ Try build successful - checks-actions
Build commit: 5d8f37a5e6b178a40e83eb040ae6522765066dba (5d8f37a5e6b178a40e83eb040ae6522765066dba)

[rust-timer]

Finished benchmarking commit (5d8f37a5e6b178a40e83eb040ae6522765066dba): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-2.6%, -2.6%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.8%	[-0.8%, -0.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.8%	[-0.8%, -0.8%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 646.537s -> 646.55s (0.00%)