Ignore core, alloc and test tests that require unwinding on -C panic=abort
#112314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
pietroalbini
force-pushed
the
pa-core-alloc-abort
branch
from
a3c64de to
0aacdaa
Compare
pietroalbini
changed the title
core and alloc tests that require unwinding on -C panic=abortcore, alloc and test tests that require unwinding on -C panic=abort
Member
Author
|
Also added attributes to the |
bjorn3
reviewed
Jun 13, 2023
Collaborator
|
Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 |
Member
Author
|
Removed the ignored tests from the patch. r? @bjorn3 |
bjorn3
reviewed
Jun 13, 2023
pietroalbini
force-pushed
the
pa-core-alloc-abort
branch
from
9ca495d to
a988dc2
Compare
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (371994e): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 648.13s -> 647.349s (-0.12%) |
bjorn3
pushed a commit
to bjorn3/rust
that referenced
this pull request
Jun 15, 2023
Ignore `core`, `alloc` and `test` tests that require unwinding on `-C panic=abort` Some of the tests for `core` and `alloc` require unwinding through their use of `catch_unwind`. These tests fail when testing using `-C panic=abort` (in my case through a target without unwinding support, and `-Z panic-abort-tests`), while they should be ignored as they don't indicate a failure. This PR marks all of these tests with this attribute: ```rust #[cfg_attr(not(panic = "unwind"), ignore = "test requires unwinding support")] ``` I'm not aware of a way to test this on rust-lang/rust's CI, as we don't test any target with `-C panic=abort`, but I tested this locally on a Ferrocene target and it does indeed make the test suite pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the tests for
coreandallocrequire unwinding through their use ofcatch_unwind. These tests fail when testing using-C panic=abort(in my case through a target without unwinding support, and-Z panic-abort-tests), while they should be ignored as they don't indicate a failure.This PR marks all of these tests with this attribute:
#[cfg_attr(not(panic = "unwind"), ignore = "test requires unwinding support")]I'm not aware of a way to test this on rust-lang/rust's CI, as we don't test any target with
-C panic=abort, but I tested this locally on a Ferrocene target and it does indeed make the test suite pass.