Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent emitting missing_docs for pub extern crate #112343

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

GuillaumeGomez
Copy link
Member

Fixes #112308.

r? @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 6, 2023
@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 6, 2023

📌 Commit 550fe63 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 6, 2023
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#111250 (Add Terminator conversion from MIR to SMIR, part #2)
 - rust-lang#112310 (Add new Tier-3 targets: `loongarch64-unknown-none*`)
 - rust-lang#112334 (Add myself to highfive rotation)
 - rust-lang#112340 (remove `TyCtxt::has_error_field` helper method)
 - rust-lang#112343 (Prevent emitting `missing_docs` for `pub extern crate`)
 - rust-lang#112350 (Avoid duplicate type sanitization of local decls in borrowck)
 - rust-lang#112356 (Fix comment for `get_region_var_origins`)
 - rust-lang#112358 (Remove default visitor impl in region constraint generation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 38ddff5 into rust-lang:master Jun 7, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 7, 2023
@GuillaumeGomez GuillaumeGomez deleted the extern-crate-missing-docs branch June 7, 2023 08:43
@Vixeliz Vixeliz mentioned this pull request Jun 25, 2023
@GuillaumeGomez GuillaumeGomez added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 11, 2023
@GuillaumeGomez
Copy link
Member Author

I nominated it to be backported into beta.

@Manishearth
Copy link
Member

approving the backport

@Mark-Simulacrum Mark-Simulacrum added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Jul 11, 2023
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.72.0, 1.71.0 Jul 12, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 12, 2023
…Simulacrum

[stable] 1.71.0 release, backports

This PR adds a last-minute backport of:

- rust-lang#112343: Prevent emitting `missing_docs` for `pub extern crate`
- no beta/mainline PR -- dropping empty section from relnotes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beta rustc warns on missing documentation for an extern crate even though the docstring is not used by rustdoc
6 participants