[do not merge] Perform ThinLTO on Windows dist builder in try builds #112377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
@bors try |
|
⌛ Trying commit 0ea7041 with merge 3dff3557cc9e0520bf0986685238778b942e15c8... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-author
|
Well, almost all mir-opt tests have failed, although the errors look a bit weird. It looks like running tests on optimized dist builds would in fact prevent this specific miscompilation. |
|
that's a very funny failure condition that would be very fun to debug if we didn't know that whitespace handling was broken :D |
|
Yes, it looks super weird with the whitespace. Still, if we got this failure before, we could prevent getting a miscompiling rustc on Windows into stable :) So hopefully next time the tests will help us find similar problems much sooner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking if the new testing of optimized artifacts would have caught the ThinLTO rustc miscompilation on Windows (#109067).
r? @ghost