Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for #105709 #112389

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Add a test for #105709 #112389

merged 1 commit into from
Jun 8, 2023
+9 −0

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Jun 7, 2023

Closes #105709

@rustbot
Copy link
Collaborator

rustbot commented Jun 7, 2023

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 7, 2023
compiler-errors
compiler-errors reviewed Jun 7, 2023
View reviewed changes
tests/ui/const-generics/generic_const_exprs/issue-105709.rs Outdated Show resolved Hide resolved
tests/ui/const-generics/generic_const_exprs/issue-105709.rs Outdated
@@ -0,0 +1,9 @@
// build-pass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could use a better issue name. Perhaps something like inline-const-in-const-generic-default or something?

@compiler-errors
Copy link
Member

Squash this into one commit, then r=me.

@TaKO8Ki TaKO8Ki force-pushed the issue-105709 branch 2 times, most recently from 9009d14 to 7a3e569 Compare June 7, 2023 18:09
@TaKO8Ki
add a test for rust-lang#105709
5e57e27 
replace build with check

Co-authored-by: Michael Goulet <michael@errs.io>

use appropriate test name
@Dylan-DPC
Copy link
Member

@bors r=compiler-errors rollup=always

@bors
Copy link
Contributor

bors commented Jun 8, 2023

📌 Commit 5e57e27 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2023
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 8, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 8, 2023
@bors
Auto merge of rust-lang#112415 - GuillaumeGomez:rollup-5pa9frd, r=Gui…
e740925 
…llaumeGomez

Rollup of 9 pull requests

Successful merges:

 - rust-lang#112034 (Migrate `item_opaque_ty` to Askama)
 - rust-lang#112179 (Avoid passing --cpu-features when empty)
 - rust-lang#112309 (bootstrap: remove dependency `is-terminal`)
 - rust-lang#112388 (Migrate GUI colors test to original CSS color format)
 - rust-lang#112389 (Add a test for rust-lang#105709)
 - rust-lang#112392 (Fix ICE for while loop with assignment condition with LHS place expr)
 - rust-lang#112394 (Remove accidental comment)
 - rust-lang#112396 (Track more diagnostics in `rustc_expand`)
 - rust-lang#112401 (Don't `use compile_error as print`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5b7eba6 into rust-lang:master Jun 8, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.

ICE: type parameter out of range when substituting
6 participants
@TaKO8Ki @rustbot @compiler-errors @Dylan-DPC @bors @oli-obk