Remove #[cfg(all())] workarounds from c_char
#112490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cuviper (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 427ff7c043241743c44276e8a823868d408dcc63 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
|
Hold on... @bors r- |
bors
added
S-waiting-on-author
cuviper
reviewed
Jun 15, 2023
| // replacing `0 as c_char` with `0_i8`/`0_u8`. This #[cfg(all())] can be removed | ||
| // after the false positive in https://github.com/rust-lang/rust-clippy/issues/8093 | ||
| // is fixed. | ||
| #[cfg(all())] | ||
| #[doc(cfg(all()))] } |
There was a problem hiding this comment.
Doesn't this apply to the doc one too?
There was a problem hiding this comment.
I don't think so, some of the other definitions have the doc one too but no clippy workaround, it seems to be to hide some rustdoc output about the required cfg #89596
|
How do you test this? I haven't tried |
Alexendoo
force-pushed
the
c-char-cfg-all
branch
from
427ff7c to
b607a8a
Compare
Alexendoo
changed the title
#[cfg(all())] from std::ffi::c_char#[cfg(all())] workarounds from c_char
|
Realised I missed one, removed that too It can be tested with |
Alexendoo
added
S-waiting-on-review
|
Thanks! @bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 22, 2023
Remove `#[cfg(all())]` workarounds from `c_char` Casts to type aliases are now ignored by Clippy rust-lang/rust-clippy#8596 Closes rust-lang/rust-clippy#8093
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 22, 2023
Remove `#[cfg(all())]` workarounds from `c_char` Casts to type aliases are now ignored by Clippy rust-lang/rust-clippy#8596 Closes rust-lang/rust-clippy#8093
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 22, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#112490 (Remove `#[cfg(all())]` workarounds from `c_char`) - rust-lang#113252 (Update the tracking issue for `const_cstr_from_ptr`) - rust-lang#113442 (Allow limited access to `OsString` bytes) - rust-lang#113876 (fix docs & example for `std::os::unix::prelude::FileExt::write_at`) - rust-lang#113898 (Fix size_hint for EncodeUtf16) - rust-lang#113934 (Multibyte character removal in String::pop and String::remove doctests) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Casts to type aliases are now ignored by Clippy rust-lang/rust-clippy#8596
Closes rust-lang/rust-clippy#8093