Replace fvdl with ffx, allow test without install #112719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
This comment has been minimized.
This comment has been minimized.
djkoloski
force-pushed
the
fuchsia_test_runner_remove_fvdl
branch
from
6e1f33d to
cd0366d
Compare
|
Some changes occurred in src/tools/cargo cc @ehuss |
tmandry
reviewed
Jun 16, 2023
djkoloski
force-pushed
the
fuchsia_test_runner_remove_fvdl
branch
from
cd0366d to
c7d9df8
Compare
|
looks like there's an unintentional submodule change |
This comment has been minimized.
This comment has been minimized.
Along with replacing fvdl uses with the equivalent ffx commands, this also switches from using the install path for libstd-*.so and libtest-*.so to using the build directory (now passed on the command line). The user no longer needs to run x.py install before running tests now, and the correct libstd and libtest are detected on run instead of startup so the test runner can handle recompilations after starting the testing environment.
djkoloski
force-pushed
the
fuchsia_test_runner_remove_fvdl
branch
from
c7d9df8 to
4c6fd75
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
|
@bors r+ rollup |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 17, 2023
…ve_fvdl, r=tmandry Replace fvdl with ffx, allow test without install Along with replacing fvdl uses with the equivalent ffx commands, this also switches from using the install path for libstd-*.so and libtest-*.so to using the build directory (now passed on the command line). The user no longer needs to run x.py install before running tests now, and the correct libstd and libtest are detected on run instead of startup so the test runner can handle recompilations after starting the testing environment. r? `@tmandry`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 17, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#112352 (Fix documentation build on FreeBSD) - rust-lang#112644 (Correct types in method descriptions of `NonZero*` types) - rust-lang#112683 (fix ICE on specific malformed asm clobber_abi) - rust-lang#112707 ([rustdoc] Fix invalid handling of "going back in history" when "go to only search result" setting is enabled) - rust-lang#112719 (Replace fvdl with ffx, allow test without install) - rust-lang#112728 (Add `<meta charset="utf-8">` to `-Zdump-mir-spanview` output) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with replacing fvdl uses with the equivalent ffx commands, this also switches from using the install path for libstd-.so and libtest-.so to using the build directory (now passed on the command line). The user no longer needs to run x.py install before running tests now, and the correct libstd and libtest are detected on run instead of startup so the test runner can handle recompilations after starting the testing environment.
r? @tmandry