-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Bound::predicates
use Clause
#112734
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @cjgillot (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Jun 17, 2023
r? @oli-obk |
compiler-errors
approved these changes
Jun 17, 2023
r? @compiler-errors @bors r+ |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 17, 2023
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Jun 18, 2023
…compiler-errors Make `Bound::predicates` use `Clause` Part of rust-lang#107250 `Bound::predicates` returns an iterator over `Binder<_, Clause>` instead of `Predicate`. I tried updating `explicit_predicates_of` as well, but it seems that it needs a lot more change than I thought. Will do it in a separate PR instead.
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Jun 18, 2023
…compiler-errors Make `Bound::predicates` use `Clause` Part of rust-lang#107250 `Bound::predicates` returns an iterator over `Binder<_, Clause>` instead of `Predicate`. I tried updating `explicit_predicates_of` as well, but it seems that it needs a lot more change than I thought. Will do it in a separate PR instead.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 18, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#107200 (io: soften ‘at most one write attempt’ requirement in io::Write::write) - rust-lang#112667 (Move WF/ConstEvaluatable goal to clause) - rust-lang#112685 (std: only depend on dlmalloc for wasm*-unknown) - rust-lang#112722 (bootstrap: check for dry run when copying env vars for msvc) - rust-lang#112734 (Make `Bound::predicates` use `Clause`) r? `@ghost` `@rustbot` modify labels: rollup
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #107250
Bound::predicates
returns an iterator overBinder<_, Clause>
instead ofPredicate
.I tried updating
explicit_predicates_of
as well, but it seems that it needs a lot more change than I thought. Will do it in a separate PR instead.