Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BorrowFlag instead of explicit isize #112757

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Use BorrowFlag instead of explicit isize #112757

merged 2 commits into from
Jun 19, 2023

Conversation

Danvil
Copy link
Contributor

@Danvil Danvil commented Jun 18, 2023

The integer type tracking borrow count has a typedef called BorrowFlag. This type should be used instead of explicit isize.

The integer type tracking borrow count has a typedef called `BorrowFlag`. This type should be used instead of explicit `isize`.
@rustbot
Copy link
Collaborator

rustbot commented Jun 18, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 18, 2023
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 19, 2023

📌 Commit 09707ee has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 19, 2023
Use BorrowFlag instead of explicit isize

The integer type tracking borrow count has a typedef called `BorrowFlag`. This type should be used instead of explicit `isize`.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 19, 2023
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#109970 ([doc] `poll_fn`: explain how to `pin` captured state safely)
 - rust-lang#112705 (Simplify `Span::source_callee` impl)
 - rust-lang#112757 (Use BorrowFlag instead of explicit isize)
 - rust-lang#112768 (Rewrite various resolve/diagnostics errors as translatable diagnostics)
 - rust-lang#112777 (Continue folding in query normalizer on weak aliases)
 - rust-lang#112780 (Treat TAIT equation as always ambiguous in coherence)
 - rust-lang#112783 (Don't ICE on bound var in `reject_fn_ptr_impls`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7d072fa into rust-lang:master Jun 19, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants