Rewrite most diagnostics as translatable within resolve/imports #112979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @fee1-dead (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
chenyukang
approved these changes
Jun 23, 2023
fee1-dead
reviewed
Jun 24, 2023
fee1-dead
reviewed
Jun 24, 2023
fee1-dead
reviewed
Jun 24, 2023
fee1-dead
approved these changes
Jun 24, 2023
fee1-dead
reviewed
Jun 24, 2023
|
Thanks. One last thing: could you squash the commits into one? |
Add translatable diagnostic for cannot be reexported error also added for subdiagnostics Add translatable diagnostics for resolve_glob_import errors Add translatable diag for unable to determine import resolution Add translatable diag for is not directly importable
NotStirred
force-pushed
the
translatable_diag/resolve_imports
branch
from
fc6d2a1 to
b7d6032
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 26, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#111326 (Add support for NetBSD/aarch64-be (big-endian arm64).) - rust-lang#112559 (Add esp-idf missing targets) - rust-lang#112840 (doc: loongarch: Update maintainers) - rust-lang#112955 (CI: cancel in-progress workflow runs after a push) - rust-lang#112979 (Rewrite most diagnostics as translatable within resolve/imports) - rust-lang#113034 (Switch some more Steps to `builder.msg`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.