bootstrap: update defaults for `compiler` and `library` aliases #112982

lukas-code · 2023-06-23T21:15:30Z

x doc compiler now documents all of compiler, not just rustc_driver.
x doc with compiler docs enabled now includes rustc-main and rustc_smir. rustc_codegen_llvm is only included if the LLVM backend is enabled, which is the default.
x doc library now excludes sysroot.
x check compiler and x check library now properly check tests/benches/examples of all compiler or library crates, respectively. Note that x check compiler will check the library artifacts, but not tests.

fixes the fallout from #111955, cc @jyn514

rustbot · 2023-06-23T21:15:38Z

r? @albertlarsan68

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-06-23T21:15:41Z

This PR changes Stable MIR

cc @oli-obk, @celinval

jyn514 · 2023-06-23T22:16:46Z

cc #112440

albertlarsan68

LGTM, r=me with this change

albertlarsan68 · 2023-07-13T14:34:23Z

compiler/rustc_smir/src/lib.rs

@@ -1,6 +1,6 @@
 //! The WIP stable interface to rustc internals.
 //!
-//! For more information see https://github.com/rust-lang/project-stable-mir
+//! For more information see <https://github.com/rust-lang/project-stable-mir>


Can you remove this change?

This triggers the rustdoc::bare_urls lint. Because this PR builds the docs for rustc_smir now, that causes the build to fail.

Thanks for the explanation

albertlarsan68 · 2023-07-13T14:46:21Z

@bors rollup

albertlarsan68 · 2023-07-13T14:55:30Z

Thanks for the PR!
@bors r+

bors · 2023-07-13T14:55:32Z

📌 Commit d9f4fb3 has been approved by albertlarsan68

It is now in the queue for this repository.

…-crates, r=albertlarsan68 bootstrap: update defaults for `compiler` and `library` aliases * `x doc compiler` now documents all of compiler, not just `rustc_driver`. * `x doc` with compiler docs enabled now includes `rustc-main` and `rustc_smir`. `rustc_codegen_llvm` is only included if the LLVM backend is enabled, which is the default. * `x doc library` now excludes `sysroot`. * `x check compiler` and `x check library` now properly check tests/benches/examples of all compiler or library crates, respectively. Note that `x check compiler` will check the library artifacts, but not tests. fixes the fallout from rust-lang#111955, cc `@jyn514`

…-crates, r=albertlarsan68 bootstrap: update defaults for `compiler` and `library` aliases * `x doc compiler` now documents all of compiler, not just `rustc_driver`. * `x doc` with compiler docs enabled now includes `rustc-main` and `rustc_smir`. `rustc_codegen_llvm` is only included if the LLVM backend is enabled, which is the default. * `x doc library` now excludes `sysroot`. * `x check compiler` and `x check library` now properly check tests/benches/examples of all compiler or library crates, respectively. Note that `x check compiler` will check the library artifacts, but not tests. fixes the fallout from rust-lang#111955, cc ``@jyn514``

…-crates, r=albertlarsan68 bootstrap: update defaults for `compiler` and `library` aliases * `x doc compiler` now documents all of compiler, not just `rustc_driver`. * `x doc` with compiler docs enabled now includes `rustc-main` and `rustc_smir`. `rustc_codegen_llvm` is only included if the LLVM backend is enabled, which is the default. * `x doc library` now excludes `sysroot`. * `x check compiler` and `x check library` now properly check tests/benches/examples of all compiler or library crates, respectively. Note that `x check compiler` will check the library artifacts, but not tests. fixes the fallout from rust-lang#111955, cc ```@jyn514```

matthiaskrgr · 2023-07-13T19:40:38Z

@bors r-
probably fails here #113669 (comment)
feel free to reapprove if you think there this is not actually the cause

lukas-code · 2023-07-13T20:13:20Z

Yeah that rollup failure is definitely caused by this PR. It's more broken docs for rustc_smir that got revealed, because this PR actually builds the docs now.

albertlarsan68 · 2023-07-13T20:18:44Z

@oli-obk, @celinval What do you think about this failure? Do not merge this PR or fix the docs?

jyn514 · 2023-07-13T20:44:01Z

certainly fix the docs

bors · 2023-07-14T02:07:58Z

☔ The latest upstream changes (presumably #113676) made this pull request unmergeable. Please resolve the merge conflicts.

albertlarsan68 · 2023-07-14T11:14:45Z

@bors r+ rollup=maybe

bors · 2023-07-14T11:14:46Z

📌 Commit 9d6bfc2 has been approved by albertlarsan68

It is now in the queue for this repository.

bors · 2023-07-14T12:09:30Z

⌛ Testing commit 9d6bfc2 with merge bacf5bc...

bors · 2023-07-14T14:03:31Z

☀️ Test successful - checks-actions
Approved by: albertlarsan68
Pushing bacf5bc to master...

rust-timer · 2023-07-14T16:13:35Z

Finished benchmarking commit (bacf5bc): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[2.2%, 3.4%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 658.312s -> 659.454s (0.17%)

rustbot assigned albertlarsan68 Jun 23, 2023

This comment has been minimized.

Sign in to view

lukas-code force-pushed the bootstrap-alias-default-crates branch 2 times, most recently from abf2ad7 to d9f4fb3 Compare June 24, 2023 11:52

albertlarsan68 reviewed Jul 13, 2023

View reviewed changes

albertlarsan68 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 13, 2023

matthiaskrgr mentioned this pull request Jul 13, 2023

Rollup of 8 pull requests #113665

Closed

matthiaskrgr mentioned this pull request Jul 13, 2023

Rollup of 7 pull requests #113667

Closed

matthiaskrgr mentioned this pull request Jul 13, 2023

Rollup of 7 pull requests #113669

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 13, 2023

lukas-code force-pushed the bootstrap-alias-default-crates branch from d9f4fb3 to 1339ccf Compare July 13, 2023 20:26

Lukas Markeffsky added 2 commits July 14, 2023 09:41

bootstrap: update defaults for compiler and library aliases

b1a5423

fix docs for rustc_smir

9d6bfc2

lukas-code force-pushed the bootstrap-alias-default-crates branch from 1339ccf to 9d6bfc2 Compare July 14, 2023 09:57

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 14, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 14, 2023

bors merged commit bacf5bc into rust-lang:master Jul 14, 2023

rustbot added this to the 1.73.0 milestone Jul 14, 2023

lukas-code deleted the bootstrap-alias-default-crates branch July 14, 2023 14:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bootstrap: update defaults for `compiler` and `library` aliases #112982

bootstrap: update defaults for `compiler` and `library` aliases #112982

lukas-code commented Jun 23, 2023 •

edited

Loading

rustbot commented Jun 23, 2023

rustbot commented Jun 23, 2023

This comment has been minimized.

jyn514 commented Jun 23, 2023

albertlarsan68 left a comment

albertlarsan68 Jul 13, 2023

lukas-code Jul 13, 2023

albertlarsan68 Jul 13, 2023

albertlarsan68 commented Jul 13, 2023

albertlarsan68 commented Jul 13, 2023

bors commented Jul 13, 2023

matthiaskrgr commented Jul 13, 2023

lukas-code commented Jul 13, 2023

albertlarsan68 commented Jul 13, 2023

jyn514 commented Jul 13, 2023

bors commented Jul 14, 2023

albertlarsan68 commented Jul 14, 2023

bors commented Jul 14, 2023

bors commented Jul 14, 2023

bors commented Jul 14, 2023

rust-timer commented Jul 14, 2023

bootstrap: update defaults for compiler and library aliases #112982

bootstrap: update defaults for compiler and library aliases #112982

Conversation

lukas-code commented Jun 23, 2023 • edited Loading

rustbot commented Jun 23, 2023

rustbot commented Jun 23, 2023

This comment has been minimized.

jyn514 commented Jun 23, 2023

albertlarsan68 left a comment

Choose a reason for hiding this comment

albertlarsan68 Jul 13, 2023

Choose a reason for hiding this comment

lukas-code Jul 13, 2023

Choose a reason for hiding this comment

albertlarsan68 Jul 13, 2023

Choose a reason for hiding this comment

albertlarsan68 commented Jul 13, 2023

albertlarsan68 commented Jul 13, 2023

bors commented Jul 13, 2023

matthiaskrgr commented Jul 13, 2023

lukas-code commented Jul 13, 2023

albertlarsan68 commented Jul 13, 2023

jyn514 commented Jul 13, 2023

bors commented Jul 14, 2023

albertlarsan68 commented Jul 14, 2023

bors commented Jul 14, 2023

bors commented Jul 14, 2023

bors commented Jul 14, 2023

rust-timer commented Jul 14, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

bootstrap: update defaults for `compiler` and `library` aliases #112982

bootstrap: update defaults for `compiler` and `library` aliases #112982

lukas-code commented Jun 23, 2023 •

edited

Loading