Fix ARM unwinding. #11301
Merged
Fix ARM unwinding. #11301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc #11281 |
| @@ -59,8 +59,7 @@ use any::{Any, AnyRefExt}; | |||
| use c_str::CString; | |||
There was a problem hiding this comment.
This file seems to have become executable
There was a problem hiding this comment.
The mode on this file (and some of them above as well) have changed from 644 to 755
There was a problem hiding this comment.
Ahh, that's what those are for!
|
updated |
| uw::_URC_HANDLER_FOUND // catch! | ||
| // ARM EHABI uses a slightly different personality routine signature, | ||
| // but otherwise works the same. | ||
| #[cfg(target_os = "android")] |
There was a problem hiding this comment.
Shouldn't this be #[cfg(target_arch = "arm")] instead?
|
@alexcrichton yes @luqmana it does seem like it should be |
|
@vadimcn awesome fix. Thanks for digging through this. |
|
@vadimcn How did you figure out what ARM needed differently here? |
bors
added a commit
that referenced
this pull request
Jan 4, 2014
This fixes stack unwinding on targets using ARM EHABI. closes #11147
|
@brson: Mostly by comparing Rust's asm output to clang's, then finding magic switches that turn on EH table generation. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 25, 2023
[`useless_conversion`]: don't lint if type parameter has unsatisfiable bounds for `.into_iter()` receiver Fixes rust-lang#11300. Before this PR, clippy assumed that if it sees a `f(x.into_iter())` call and the type at that argument position is generic over any `IntoIterator`, then the `.into_iter()` call must be useless because `x` already implements `IntoIterator`, *however* this assumption is not right if the generic parameter has more than just the `IntoIterator` bound (because other traits can be implemented for the IntoIterator target type but not the IntoIterator implementor, as can be seen in the linked issue: `<[i32; 3] as IntoIterator>::IntoIter` satisfies `ExactSizeIterator`, but `[i32; 3]` does not). So, this PR makes it check that the type parameter only has a single `IntoIterator` bound. It *might* be possible to check if the type of `x` in `f(x.into_iter())` satisfies all the bounds on the generic type parameter as defined on the function (which would allow removing the `.into_iter()` call even with multiple bounds), however I'm not sure how to do that, and the current fix should always work. **Edit:** This PR has been changed to check if any of the bounds don't hold for the type of the `.into_iter()` receiver, so we can still lint in some cases. changelog: [`useless_conversion`]: don't lint `.into_iter()` if type parameter has multiple bounds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes stack unwinding on targets using ARM EHABI.
closes #11147