rust-installer & rls: remove exclusion from rustfmt & tidy #113010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ozkanonur (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-meta
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
rustbot
added
the
S-blocked
|
Note for self: add #112884 (comment) back |
|
Is rls still maintained? |
I see it here https://rust-lang.github.io/rustup-components-history/ so yes, until removed? Currently rls is just stab to warn about deprecation. |
onur-ozkan
reviewed
Jun 25, 2023
src/tools/tidy/src/bins.rs
Outdated
| @@ -95,6 +95,15 @@ mod os_impl { | |||
| return true; | |||
| } | |||
|
|
|||
| // FIXME: remove this when rust-installer test sh files changed | |||
There was a problem hiding this comment.
Some extra details would be helpful.
There was a problem hiding this comment.
Reworded in RI_EXCLUSION_LIST.
This comment has been minimized.
This comment has been minimized.
|
@rustbot label -S-blocked |
rustbot
removed
the
S-blocked
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 5, 2023
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#113010 (rust-installer & rls: remove exclusion from rustfmt & tidy ) - rust-lang#113317 ( -Ztrait-solver=next: stop depending on old solver) - rust-lang#113319 (`TypeParameterDefinition` always require a `DefId`) - rust-lang#113320 (Add some extra information to opaque type cycle errors) - rust-lang#113321 (Move `ty::ConstKind` to `rustc_type_ir`) - rust-lang#113337 (Winnow specialized impls during selection in new solver) - rust-lang#113355 (Move most coverage code out of `rustc_codegen_ssa`) - rust-lang#113356 (Add support for NetBSD/riscv64 aka. riscv64gc-unknown-netbsd.) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #112884rust-installerandrlsno longer submodules, but not removed from exclude list for rustfmt and tidy, preventing running fmt and lints on them.