Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mutable-value iterators to extra::treemap #11321

Merged
merged 3 commits into from
Jan 6, 2014
Merged

Conversation

huonw
Copy link
Member

@huonw huonw commented Jan 5, 2014

This requires a single *mut pointer to implement; I've justified its existence & correctness in the code.

Also, converts the mutable and immutable iterators to share code with some macro madness manipulation.

@DaGenix
Copy link

DaGenix commented Jan 5, 2014

Depending on what happens with #11001, it might make sense to rename these Iterators. If this lands first and if its decided to merge #11001, I'll add that renaming to that PR.

@huonw
Copy link
Member Author

huonw commented Jan 5, 2014

Sounds good. :)

bors added a commit that referenced this pull request Jan 6, 2014
This requires a single `*mut` pointer to implement; I've justified its existence & correctness in the code.

Also, converts the mutable and immutable iterators to share code with some macro ~~madness~~ manipulation.
@bors bors closed this Jan 6, 2014
@bors bors merged commit a9a348f into rust-lang:master Jan 6, 2014
@huonw huonw deleted the treemap-mut branch February 25, 2014 05:28
flip1995 pushed a commit to flip1995/rust that referenced this pull request Aug 24, 2023
allow calling `to_owned` on borrowed value for [`implicit_clone`]

fixes: rust-lang#11281

a small and simple fix that give up checking for `referenced_value.to_owned()` usage.

changelog: allow calling `to_owned` with borrowed value for [`implicit_clone`]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants