-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve typerelative ctors to adt #113217
Merged
bors
merged 6 commits into
rust-lang:master
from
ericmarkmartin:lower-type-relative-ctor-to-adt
Jul 8, 2023
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
76a7772
resolve typerelative ctors to adt
ericmarkmartin 7dfb9ed
add regression test
ericmarkmartin b9e991a
add thir-print test
ericmarkmartin 07b1912
refactor
ericmarkmartin afccc44
add mir dump test
ericmarkmartin 261c023
rename constants in mir dump test
ericmarkmartin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
// run-pass | ||
|
||
#[derive(PartialEq, Eq)] | ||
pub enum Foo { | ||
FooA(()), | ||
FooB(Vec<()>), | ||
} | ||
|
||
impl Foo { | ||
const A1: Foo = Foo::FooA(()); | ||
const A2: Foo = Self::FooA(()); | ||
const A3: Self = Foo::FooA(()); | ||
const A4: Self = Self::FooA(()); | ||
} | ||
|
||
fn main() { | ||
let foo = Foo::FooA(()); | ||
|
||
match foo { | ||
Foo::A1 => {}, | ||
_ => {}, | ||
} | ||
|
||
match foo { | ||
Foo::A2 => {}, | ||
_ => {}, | ||
} | ||
|
||
match foo { | ||
Foo::A3 => {}, | ||
_ => {}, | ||
} | ||
|
||
match foo { | ||
Foo::A4 => {}, | ||
_ => {}, | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
// compile-flags: -Z unpretty=thir-flat | ||
// check-pass | ||
|
||
// Previously, the constants with `Self::Bar(())` would be `Call`s instead of | ||
// `Adt`s in THIR. | ||
|
||
pub enum Foo { | ||
Bar(()), | ||
} | ||
|
||
impl Foo { | ||
const BAR1: Foo = Foo::Bar(()); | ||
const BAR2: Foo = Self::Bar(()); | ||
const BAR3: Self = Foo::Bar(()); | ||
const BAR4: Self = Self::Bar(()); | ||
} | ||
|
||
fn main() {} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid having to do it in all branches.