-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #113429
Rollup of 8 pull requests #113429
Conversation
…st-lang#113283) Verify that `PartialEq` implementations do not break type inference when comparing types across different allocators. This catches a regression in current nightly introduced in 001b081 (alloc: Allow comparing `Box`s over different allocators") `Box` is the only type that currently impelements this, but tests are included for `Rc` and `Arc` to prevent future regresssions.
This reverts commit 001b081. This change was done as the above commit introduces a regression in type inference. Regression test located at `tests/ui/type-inference/issue-113283-alllocator-trait-eq.rs`
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
…li-obk Simplify duplicate checks for mir validator This removes unnecessary allocations & is less code.
Fix incorrect documented default bufsize in bufreader/writer
…e, r=lcnr Don't call `type_of` on TAIT in defining scope in new solver It's *never* productive to call `consider_auto_trait_candidate` on a TAIT in the defining scope, since it will always lead to a query cycle since we call `type_of` on the TAIT. So let's just don't. I've reserved this behavior just to `SolverMode::Normal` just to avoid any future problems, since this is *technically* incomplete since we're discarding a candidate that could *theoretically* apply. But given such candidate assembly *always* leads to a query cycle, I think it's relatively low risk, and I could be convinced otherwise and make this apply to both solver mode. I assume it's far less likely to be encountered in coherence, though. This is much more likely to encounter in the new solver, though it can also be encountered in the old solver too, so I'm happy to discuss whether this new behavior we even want in the first place... I encountered this in a couple of failing UI tests: * `tests/ui/type-alias-impl-trait/issue-62000-associate-impl-trait-lifetimes.rs` * `tests/ui/type-alias-impl-trait/issue-93411.rs` r? `@lcnr`
…-errors Add a regression test for rust-lang#109054 Closes rust-lang#109054 r? ``@compiler-errors``
…, r=m-ou-se Revert "alloc: Allow comparing Boxs over different allocators", add regression test Temporary fix for rust-lang#113283 Adds a test to fix the regression introduced in 001b081 and revert that commit. The test fails without the revert.
…obj, r=lcnr Prefer object candidates in new selection `dyn Any` shouldn't be using [this implementation](https://doc.rust-lang.org/std/any/trait.Any.html#impl-Any-for-T) during codegen. Prefer object candidates over other candidates, except for other object candidates.
…er-errors Avoid calling item_name for RPITIT Fixes rust-lang#113405 r? `@compiler-errors`
…er-errors Do not assert >1 RPITITs on collect_return_position_impl_trait_in_trait_tys Fixes rust-lang#113403 Assert on collect_return_position_impl_trait_in_trait_tys is not correct when we call it from type_of(GAT). The included test is an example of a situation that collector collects 0 types. r? `@compiler-errors`
@bors r+ rollup=never p=8 |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR:
previous master: bb548f9645 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (7cc3da0): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 656.634s -> 658.984s (0.36%) |
Successful merges:
type_of
on TAIT in defining scope in new solver #112825 (Don't calltype_of
on TAIT in defining scope in new solver)type_alias_impl_trait
with lifetime #109054)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup