Sync portable-simd to 2023 July 07 #113437

workingjubilee · 2023-07-07T10:55:53Z

…ove-autosplats

…r=workingjubilee Sync portable-simd for bitmasks &c. In the ideal case, where everything works easily and nothing has to be rearranged, it is as simple as: - `git subtree pull -P library/portable-simd https://github.com/rust-lang/portable-simd - ${branch}` - write the commit message - `python x.py test --stage 1` to make sure it runs - `git push` to your PR-to-rustc branch If anything borks up this flow, you can fix it with sufficient git wizardry but you are usually better off going back to the source, fixing it, and starting over, before you open the PR. r? `@calebzulawski`

This updates the standard library's documentation to use the new syntax. The documentation is worthwhile to update as it should be more idiomatic (particularly for features like this, which are nice for users to get acquainted with). The general codebase is likely more hassle than benefit to update: it'll hurt git blame, and generally updates can be done by folks updating the code if (and when) that makes things more readable with the new format. A few places in the compiler and library code are updated (mostly just due to already having been done when this commit was first authored).

It looks like the last time had left some remaining cfg's -- which made me think that the stage0 bump was actually successful. This brings us to a released 1.62 beta though.

This PR will fix some typos detected by [typos]. I only picked the ones I was sure were spelling errors to fix, mostly in the comments. [typos]: https://github.com/crate-ci/typos

These were likely from before the `PartialEq<str>` impl for `&String`.

Sync up to rust-lang/portable-simd@8527625

Co-authored-by: Jacob Lifshay <programmerjake@gmail.com>

…number casts to number traits.

Sync up to rust-lang/portable-simd@7c7dbe0

workingjubilee · 2023-07-07T11:14:49Z

Needed to unbreak a build.

@bors r+ p=1 rollup=never

bors · 2023-07-07T11:14:51Z

📌 Commit 8765f91 has been approved by workingjubilee

It is now in the queue for this repository.

workingjubilee · 2023-07-07T11:26:21Z

@bors r-

Old fn were slightly divergent.

rustbot · 2023-07-07T11:34:05Z

The Miri subtree was changed

cc @rust-lang/miri

workingjubilee · 2023-07-07T11:34:31Z

It's a party for the whole family!

workingjubilee · 2023-07-07T11:46:47Z

@bors r+

bors · 2023-07-07T11:46:49Z

📌 Commit 37fea34 has been approved by workingjubilee

It is now in the queue for this repository.

bors · 2023-07-07T13:15:15Z

⌛ Testing commit 37fea34 with merge fd68a6d...

bors · 2023-07-07T15:42:22Z

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing fd68a6d to master...

rust-timer · 2023-07-07T16:59:10Z

Finished benchmarking commit (fd68a6d): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.6%	[1.6%, 1.6%]	1
Improvements ✅ (primary)	-1.0%	[-1.5%, -0.6%]	11
Improvements ✅ (secondary)	-1.0%	[-1.7%, -0.6%]	4
All ❌✅ (primary)	-1.0%	[-1.5%, -0.6%]	11

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.4%]	6
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-0.1%, 0.4%]	7

Bootstrap: 657.277s -> 657.311s (0.01%)

workingjubilee · 2023-07-07T17:58:06Z

errr I choose to assert the numbers are Good, Actually? you could hypothetically persuade me otherwise.

Kobzol · 2023-07-07T18:04:14Z

I oficially declare these numbers to be Good™.

@rustbot label: +perf-regression-triaged

workingjubilee and others added 30 commits December 2, 2021 18:27

Merge commit 'a8385522ade6f67853edac730b5bf164ddb298fd' into simd-rem…

af2bc4e

…ove-autosplats

Merge commit '533f0fc81ab9ba097779fcd27c8f9ea12261fef5' into psimd

35883a7

Sync rust-lang/portable-simd@03f6fbb

efb20c2

Switch bootstrap cfgs

8adbb99

Sync rust-lang/portable-simd@5f49d4c

754e077

Fix unused_doc_comments lint errors

700972b

Sync portable-simd to rust-lang/portable-simd@72df4c4

94c7da0

portable-simd: use simd_arith_offset to avoid ptr-int transmutation

62e239c

Finish bumping stage0

352e7b3

It looks like the last time had left some remaining cfg's -- which made me think that the stage0 bump was actually successful. This brings us to a released 1.62 beta though.

Sync core::simd up to rust-lang/portable-simd@2e081db

210275c

Fix a bunch of typo

e2aec07

This PR will fix some typos detected by [typos]. I only picked the ones I was sure were spelling errors to fix, mostly in the comments. [typos]: https://github.com/crate-ci/typos

separate the receiver from arguments in HIR under /clippy

1a6a069

Fix rustdoc lints

6afcb85

Remove unnecessary &format!

3cb40e5

These were likely from before the `PartialEq<str>` impl for `&String`.

Match unmatched backticks in library/

ddcb68a

remove some unneeded imports

2806570

Merge from rustc

92a6d25

Merge from rustc

a0d853c

Make sure that signatures aren't accidental refinements

a2cdcd5

Merge from rustc

1ff41d3

Sync portable-simd to 2023 May 10

a978408

Sync up to rust-lang/portable-simd@8527625

Correct swizzle_dyn cfg for armv7 neon

c7f6aae

Add a prelude

b3b5cfc

Ignore doctest

9e818d6

Add Simd, Mask, simd_swizzle to prelude

c55e19c

Co-authored-by: Jacob Lifshay <programmerjake@gmail.com>

Hide repr attribute from doc of types without guaranteed repr

048264e

Remove cast_ptr in favor of cast which acts like pointer::cast. Move …

6626cd8

…number casts to number traits.

Simplify to_int_unchecked

f4ee1ab

This comment has been minimized.

Sign in to view

Sync portable-simd to 2023 July 07

8765f91

Sync up to rust-lang/portable-simd@7c7dbe0

workingjubilee force-pushed the sync-simd-2023-july-07 branch from 37a94ef to 8765f91 Compare July 7, 2023 11:07

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2023

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 7, 2023

Use new std::simd fn in miri tests

37fea34

Old fn were slightly divergent.

oli-obk approved these changes Jul 7, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 7, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 7, 2023

bors merged commit fd68a6d into rust-lang:master Jul 7, 2023

rustbot added this to the 1.72.0 milestone Jul 7, 2023

rustbot added the perf-regression Performance regression. label Jul 7, 2023

rustbot added the perf-regression-triaged The performance regression has been triaged. label Jul 7, 2023

workingjubilee deleted the sync-simd-2023-july-07 branch July 10, 2023 05:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sync portable-simd to 2023 July 07 #113437

Sync portable-simd to 2023 July 07 #113437

workingjubilee commented Jul 7, 2023

This comment has been minimized.

workingjubilee commented Jul 7, 2023

bors commented Jul 7, 2023

This comment has been minimized.

workingjubilee commented Jul 7, 2023

rustbot commented Jul 7, 2023

workingjubilee commented Jul 7, 2023

workingjubilee commented Jul 7, 2023

bors commented Jul 7, 2023

bors commented Jul 7, 2023

bors commented Jul 7, 2023

rust-timer commented Jul 7, 2023

workingjubilee commented Jul 7, 2023

Kobzol commented Jul 7, 2023

Sync portable-simd to 2023 July 07 #113437

Sync portable-simd to 2023 July 07 #113437

Conversation

workingjubilee commented Jul 7, 2023

This comment has been minimized.

workingjubilee commented Jul 7, 2023

bors commented Jul 7, 2023

This comment has been minimized.

workingjubilee commented Jul 7, 2023

rustbot commented Jul 7, 2023

workingjubilee commented Jul 7, 2023

workingjubilee commented Jul 7, 2023

bors commented Jul 7, 2023

bors commented Jul 7, 2023

bors commented Jul 7, 2023

rust-timer commented Jul 7, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Binary size

workingjubilee commented Jul 7, 2023

Kobzol commented Jul 7, 2023