fix: skip cast if Ctor
has an invalid type
#113446
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112630
#112630 encounters an ice because it does not report the
fn({type error}) -> xxx
earlier and eventually causes a panic inmir_cast_kind
.In this PR, I made that
type_of
returnsTyKind::Error
to ensure it enters theif let Err(guar) = (t_expr, t_cast).error_reported() { xxxx }
branch in check_expr_cast in order to bypass the cast for invalid type.