Avoid calling report_forbidden_specialization for RPITITs #113456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
requested changes
Jul 7, 2023
tests/ui/async-await/in-trait/missing-feature-flag.current.stderr
Outdated
Show resolved
Hide resolved
spastorino
changed the title
compiler-errors
approved these changes
Jul 7, 2023
| @@ -722,7 +722,9 @@ pub(super) fn check_specialization_validity<'tcx>( | |||
| let result = opt_result.unwrap_or(Ok(())); | |||
|
|
|||
| if let Err(parent_impl) = result { | |||
| report_forbidden_specialization(tcx, impl_item, parent_impl); | |||
| if !tcx.is_impl_trait_in_trait(impl_item) { | |||
There was a problem hiding this comment.
Have delayed a bug, but please would rather if you check what I did what you meant and if the english wording is fine :).
There was a problem hiding this comment.
It's just a bug so it's fine.
spastorino
commented
Jul 7, 2023
| @@ -722,7 +722,9 @@ pub(super) fn check_specialization_validity<'tcx>( | |||
| let result = opt_result.unwrap_or(Ok(())); | |||
|
|
|||
| if let Err(parent_impl) = result { | |||
| report_forbidden_specialization(tcx, impl_item, parent_impl); | |||
| if !tcx.is_impl_trait_in_trait(impl_item) { | |||
There was a problem hiding this comment.
I've added this to avoid calling report_forbidden_specialization because all it does https://github.com/spastorino/rust/blob/518f84ba766d503cb709f753a0a498d87b942dd0/compiler/rustc_hir_analysis/src/check/mod.rs#L172-L182 is emit an error about an impl element that is not marked as default and that doesn't make any sense for a synthesized RPIT.
@compiler-errors would you prefer a code comment about this instead?
|
@bors r=compiler-errors rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 8, 2023
…er-errors Avoid calling report_forbidden_specialization for RPITITs Fixes rust-lang#113438 r? `@compiler-errors`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 8, 2023
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#113413 (Add needs-triage to all new issues) - rust-lang#113426 (Don't ICE in `resolve_bound_vars` when associated return-type bounds are in bad positions) - rust-lang#113427 (Remove `variances_of` on RPITIT GATs, remove its one use-case) - rust-lang#113441 (miri: check that assignments do not self-overlap) - rust-lang#113453 (Remove unused from_method from rustc_on_unimplemented) - rust-lang#113456 (Avoid calling report_forbidden_specialization for RPITITs) - rust-lang#113466 (Update cargo) - rust-lang#113467 (Fix comment of `fn_can_unwind`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113438
r? @compiler-errors