Don't normalize projections referencing type error #113472
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see UI test for example referenced here: If we try to equate the projection goal
<[type error] as Mirror>::Assoc
against an impl header that looks like<Wrapper<?0> as Mirror>::Assoc
, this will succeed without constraining?0
since[type error]
unifies with everything.This means that sometimes we can get a non-ambiguous response that does not constrain a projection, which causes these assertions to trigger in some UI tests:
rust/compiler/rustc_hir_typeck/src/writeback.rs
Lines 139 to 142 in eee6b31
rust/compiler/rustc_traits/src/normalize_erasing_regions.rs
Line 50 in eee6b31
r? @lcnr