Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide compiler_builtins in the prelude #113557

Merged
merged 1 commit into from
Jul 16, 2023
Merged

Hide compiler_builtins in the prelude #113557

merged 1 commit into from
Jul 16, 2023

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Jul 10, 2023

This crate is a private implementation detail. We only need to insert it into the crate graph for linking and should not expose any of its public API.

Fixes #113533

@rustbot
Copy link
Collaborator

rustbot commented Jul 10, 2023

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 10, 2023
@Amanieu Amanieu mentioned this pull request Jul 10, 2023
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@petrochenkov
Copy link
Contributor

I'd suggest to not generate an extern crate item for compiler_builtins at all, and link them directly in the same way as profiler builtins or panic runtimes - #109421 (comment).

This also needs a crater run, just in case.

@Amanieu Amanieu mentioned this pull request Jul 11, 2023
Closed
@Amanieu Amanieu force-pushed the no-builtins-prelude branch from 6555667 to 2eec117 Compare July 11, 2023 19:51
@rust-log-analyzer

This comment has been minimized.

Sign in to view
Amanieu added a commit to Amanieu/rust that referenced this pull request Jul 12, 2023
@Amanieu
Inject compiler_builtins during crate resolution
4f9fdca 
This is an alternative to rust-lang#113557 which removes `compiler_builtins` from
the prelude and injects it during crate resolution instead.

Fixes rust-lang#113533
@Amanieu Amanieu mentioned this pull request Jul 12, 2023
Closed
@petrochenkov
Copy link
Contributor

r? @petrochenkov

@rustbot rustbot assigned petrochenkov and unassigned TaKO8Ki Jul 14, 2023
@petrochenkov
Copy link
Contributor

Could you add a FIXME saying that #113634 is preferable, but we cannot do it right now due to issues?

@petrochenkov
Copy link
Contributor

This will need a crater run after CI is green.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2023
@Amanieu
Hide compiler_builtins in the prelude
07f855d 
This crate is a private implementation detail. We only need to insert it
into the crate graph for linking and should not expose any of its public
API.

Fixes rust-lang#113533
@Amanieu Amanieu force-pushed the no-builtins-prelude branch from 2eec117 to 07f855d Compare July 14, 2023 15:53
@petrochenkov
Copy link
Contributor

@bors try

@bors
Copy link
Collaborator

bors commented Jul 14, 2023

⌛ Trying commit 07f855d with merge d9354925cd91f64ab927cdf338a7fe5ee98a62cd...

@petrochenkov petrochenkov added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 14, 2023
@bors
Copy link
Collaborator

bors commented Jul 14, 2023

☀️ Try build successful - checks-actions
Build commit: d9354925cd91f64ab927cdf338a7fe5ee98a62cd (d9354925cd91f64ab927cdf338a7fe5ee98a62cd)

@Amanieu
Copy link
Member Author

Amanieu commented Jul 14, 2023

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-113557 created and queued.
🤖 Automatically detected try build d9354925cd91f64ab927cdf338a7fe5ee98a62cd
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-113557 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-113557 is completed!
📊 23 regressed and 2 fixed (323482 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jul 16, 2023
@Amanieu
Copy link
Member Author

Amanieu commented Jul 16, 2023

Crater failures are all due to running out of disk space.

@petrochenkov
Copy link
Contributor

All the regressions are spurious.
@bors r+

@bors
Copy link
Collaborator

bors commented Jul 16, 2023

📌 Commit 07f855d has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2023
@bors
Copy link
Collaborator

bors commented Jul 16, 2023

⌛ Testing commit 07f855d with merge 4a07b2b...

@bors
Copy link
Collaborator

bors commented Jul 16, 2023

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 4a07b2b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 16, 2023
@bors bors merged commit 4a07b2b into rust-lang:master Jul 16, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 16, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4a07b2b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.2% [3.2%, 3.2%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 657.74s -> 658.073s (0.05%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.

Macros exported by compiler_builtins should not be in the prelude
8 participants
@Amanieu @rustbot @rust-log-analyzer @petrochenkov @bors @craterbot @rust-timer @TaKO8Ki