-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(rustc_middle): Substs -> GenericArg #113591
Conversation
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
@rustbot label -S-waiting-on-review +S-waiting-on-author |
r? ghost |
Failed to set assignee to
|
f4449f8
to
054053f
Compare
This comment has been minimized.
This comment has been minimized.
054053f
to
e471156
Compare
This comment has been minimized.
This comment has been minimized.
0e81e7e
to
1bffadb
Compare
This comment has been minimized.
This comment has been minimized.
1bffadb
to
c12b730
Compare
13eee97
to
0095115
Compare
This comment has been minimized.
This comment has been minimized.
3276d69
to
074f279
Compare
This comment has been minimized.
This comment has been minimized.
074f279
to
3665033
Compare
This comment has been minimized.
This comment has been minimized.
☀️ Test successful - checks-actions |
Finished benchmarking commit (5767cad): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 659.454s -> 657.557s (-0.29%) |
Fallout from rust-lang/rust#113591
resolves #110793
SubstsRef
andInternalSubsts
toGenericArgsRef<'tcx>
andGenericArgs<'tcx>
.substs
toargs
.ty::subst
toty::generic_args
or sth. Make that module private and publicly reexport its content in the ty module.EarlyBinder::subst(_identity)
toEarlyBinder::instantiate(_identity)
.[a-zA-Z]+Substs
renamed toXArgs
.substs
now useargs
orgeneric_args
(mostly the former).However, the verb of "substituting" is still being used here and there, mostly in comments. I think that can be a separate PR as part of #110254 to change the verb to
replace_generics
or something similar.