Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print artifact sizes in opt-dist #113685

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Print artifact sizes in opt-dist #113685

merged 1 commit into from
Jul 14, 2023

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jul 14, 2023

The Python PGO script printed a nice table of artifact sizes (librustc_driver.so, libLLVM.so, ...) at the end of the CI run, which was useful to quickly see the sizes of important files. I forgot to port this functionality into the Rust (opt-dist) version in #112235. This PR fixes that.

r? bootstrap

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 14, 2023
@Kobzol
Copy link
Contributor Author

Kobzol commented Jul 14, 2023

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 14, 2023
@bors
Copy link
Contributor

bors commented Jul 14, 2023

⌛ Trying commit b06554a7ca628a9d363960855ed666558faafd65 with merge bebdc7f6811e776ded6a61e1e30b4a356b369437...

@Mark-Simulacrum
Copy link
Member

r=me

@bors
Copy link
Contributor

bors commented Jul 14, 2023

💔 Test failed - checks-actions

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2023
@Kobzol Kobzol force-pushed the opt-dist-binary-sizes branch from b06554a to ecf82a3 Compare July 14, 2023 12:54
@Kobzol
Copy link
Contributor Author

Kobzol commented Jul 14, 2023

@bors try

@bors
Copy link
Contributor

bors commented Jul 14, 2023

⌛ Trying commit ecf82a3f8cdd38fbda54f75201d346eec60ad93e with merge 4578898ac1a0eb7d5726035cbeff7af234ac6996...

@bors
Copy link
Contributor

bors commented Jul 14, 2023

💔 Test failed - checks-actions

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kobzol Kobzol force-pushed the opt-dist-binary-sizes branch from ecf82a3 to 18305ea Compare July 14, 2023 14:07
@Kobzol
Copy link
Contributor Author

Kobzol commented Jul 14, 2023

@bors try

@bors
Copy link
Contributor

bors commented Jul 14, 2023

⌛ Trying commit 18305ea with merge 85d5e826f79e0ab28a5cee2fcdb840bcd5a45143...

@bors
Copy link
Contributor

bors commented Jul 14, 2023

☀️ Try build successful - checks-actions
Build commit: 85d5e826f79e0ab28a5cee2fcdb840bcd5a45143 (85d5e826f79e0ab28a5cee2fcdb840bcd5a45143)

@rust-timer

This comment has been minimized.

Sign in to view
@Kobzol
Copy link
Contributor Author

Kobzol commented Jul 14, 2023

Finally.

@bors r=Mark-Simulacrum rollup

@bors
Copy link
Contributor

bors commented Jul 14, 2023

📌 Commit 18305ea has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 14, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 14, 2023
@matthiaskrgr
Rollup merge of rust-lang#113685 - Kobzol:opt-dist-binary-sizes, r=Ma…
f021136 
…rk-Simulacrum

Print artifact sizes in `opt-dist`

The Python PGO script printed a nice table of artifact sizes (`librustc_driver.so`, `libLLVM.so`, ...) at the end of the CI run, which was useful to quickly see the sizes of important files. I forgot to port this functionality into the Rust (`opt-dist`) version in rust-lang#112235. This PR fixes that.

r? bootstrap
This was referenced Jul 14, 2023
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 14, 2023
@bors
Auto merge of rust-lang#113703 - matthiaskrgr:rollup-19uhwuh, r=matth…
3b55d23 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#113599 (Use maybe_body_owned_by for multiple suggestions)
 - rust-lang#113662 (Rename VecDeque's `rotate_left` and `rotate_right` parameters)
 - rust-lang#113681 (rustdoc-json: Add test for private supertrait.)
 - rust-lang#113682 (trait system refactor ping: also apply to nested modules of `solve`)
 - rust-lang#113685 (Print artifact sizes in `opt-dist`)
 - rust-lang#113688 (llvm-wrapper: update for LLVM API change)
 - rust-lang#113692 (tests: adapt for removal of -opaque-pointers in LLVM 17)
 - rust-lang#113698 (Make it clearer that we're just checking for an RPITIT)
 - rust-lang#113699 (update Miri)

Failed merges:

 - rust-lang#113625 (Structurally normalize in selection)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit dae9e40 into rust-lang:master Jul 14, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 14, 2023
@Kobzol Kobzol deleted the opt-dist-binary-sizes branch July 14, 2023 21:16
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (85d5e826f79e0ab28a5cee2fcdb840bcd5a45143): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.3% [0.3%, 0.4%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.7% [0.7%, 0.7%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.0% [-3.6%, -2.5%] 2
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 9.7% [3.0%, 12.6%] 7
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 659.454s -> 659.146s (-0.05%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Kobzol @rust-timer @bors @Mark-Simulacrum @rust-log-analyzer @rustbot