Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract a create_wrapper_function for use in allocator shim writing #113722

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Jul 15, 2023

This deduplicates some logic and makes it easier to follow what wrappers are produced. In the future it may allow moving the code to determine which wrappers to create to cg_ssa.

@rustbot
Copy link
Collaborator

rustbot commented Jul 15, 2023

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 15, 2023
@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Aug 1, 2023

☔ The latest upstream changes (presumably #105545) made this pull request unmergeable. Please resolve the merge conflicts.

This deduplicates some logic and makes it easier to follow what wrappers
are produced. In the future it may allow moving the code to determine
which wrappers to create to cg_ssa.
@jackh726
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 13, 2023

📌 Commit 49ae3b7 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2023
@bors
Copy link
Contributor

bors commented Aug 13, 2023

⌛ Testing commit 49ae3b7 with merge 644e806...

@bors
Copy link
Contributor

bors commented Aug 13, 2023

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 644e806 to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Aug 13, 2023

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 644e806 to master...

@bors bors added merged-by-bors This PR was explicitly merged by bors. labels Aug 13, 2023
@bors bors merged commit 644e806 into rust-lang:master Aug 13, 2023
12 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Aug 13, 2023
@bjorn3 bjorn3 deleted the allocator_shim_refactor branch August 13, 2023 19:11
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (644e806): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.4% [2.0%, 2.8%] 2
Regressions ❌
(secondary)
3.0% [2.6%, 3.4%] 2
Improvements ✅
(primary)
-4.3% [-4.3%, -4.3%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.2% [-4.3%, 2.8%] 3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 633.947s -> 632.481s (-0.23%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants