Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid another gha group nesting #113800

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Avoid another gha group nesting #113800

merged 1 commit into from
Jul 20, 2023

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jul 17, 2023

fixes #113798 (x test error_index_generator did not work locally anymore)

r? @jyn514

@rustbot
Copy link
Collaborator

rustbot commented Jul 17, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jyn514 (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 17, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
jyn514
jyn514 approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems good other than my one comment 👍 I've been using explicit drop() for the guards and it would be nice to settle on one style but I don't feel strongly on which it should be

src/bootstrap/test.rs Outdated Show resolved Hide resolved
klensy
klensy reviewed Jul 17, 2023
View reviewed changes
src/bootstrap/test.rs Outdated Show resolved Hide resolved
@jyn514
Copy link
Member

jyn514 commented Jul 19, 2023

i won't have time to look at this for a while. r=me unless you want to make more changes.

r? bootstrap

@rustbot rustbot assigned Mark-Simulacrum and unassigned jyn514 Jul 19, 2023
@jyn514 jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2023
@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 20, 2023

@bors r=jyn514

@bors
Copy link
Contributor

bors commented Jul 20, 2023

📌 Commit 7de9b65 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 20, 2023
@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 20, 2023

@bors rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 20, 2023
@matthiaskrgr
Rollup merge of rust-lang#113800 - oli-obk:gha_ci_cycle, r=jyn514
4497c9b 
Avoid another gha group nesting

fixes rust-lang#113798 (`x test error_index_generator` did not work locally anymore)

r? `@jyn514`
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 20, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 20, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 20, 2023
@bors
Auto merge of rust-lang#113890 - matthiaskrgr:rollup-k1w2vii, r=matth…
092e4f4 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#110765 (rustdoc: fix position of `default` in method rendering)
 - rust-lang#113529 (Permit pre-evaluated constants in simd_shuffle)
 - rust-lang#113800 (Avoid another gha group nesting)
 - rust-lang#113827 (Add Foreign, Never, FnDef, Closure and Generator tys to SMIR)
 - rust-lang#113835 (new solver: don't consider blanket impls multiple times)
 - rust-lang#113883 (Remove outdated Firefox-specific CSS for search's crate selector appearance)
 - rust-lang#113884 (Don't translate compiler-internal bug messages)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6102785 into rust-lang:master Jul 20, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klensy klensy klensy left review comments

@jyn514 jyn514 jyn514 approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.

x test error_index_generator triggers 'nested groups are not supported by GHA' check
7 participants
@oli-obk @rustbot @rust-log-analyzer @jyn514 @bors @klensy @Mark-Simulacrum