Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore #![no_builtins] crates participation in LTO. #113923

Merged
merged 10 commits into from
Dec 1, 2023
Merged

Restore #![no_builtins] crates participation in LTO. #113923

merged 10 commits into from
Dec 1, 2023

Commits on Oct 15, 2023

  1. Restore #![no_builtins] crates participation in LTO. 

    After rust-lang#113716, we can make `#![no_builtins]` crates participate in LTO again.
`#![no_builtins]` with LTO does not result in undefined references to the error.
    @DianQK
    DianQK committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    5200817 View commit details
    Browse the repository at this point in the history

  2. Removes the useless DisableSimplifyLibCalls parameter. 

    After applying no_builtins to the function attributes, we can remove the
DisableSimplifyLibCalls parameter.
    @DianQK
    DianQK committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    6762d64 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Add PreservedSymbols from LLVM to LTO. 

    When building with LTO, builtin functions that are defined but whose calls have not been inserted yet, get internalized.
We need to prevent these symbols from being internalized at LTO time.

Refer to https://reviews.llvm.org/D49434.
    @DianQK
    DianQK committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    a6f7596 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Update tests/run-make/wasm-builtins-import/main.rs 

    clarify seemingly circular reference
    @pnkfelix
    pnkfelix authored Oct 17, 2023
    Configuration menu
    Copy the full SHA
    7d06751 View commit details
    Browse the repository at this point in the history

  2. Update tests/run-make/wasm-builtins-import/main.rs 

    placate tidy (hopefully)
    @pnkfelix
    pnkfelix authored Oct 17, 2023
    Configuration menu
    Copy the full SHA
    665da1e View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2023

  1. Treat extern in compiler-builtins as used 

    We have to preserve the symbols of the built-in functions during LTO.
    @DianQK
    DianQK committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    b592f29 View commit details
    Browse the repository at this point in the history

  2. Removes fields from CrateInfo that are no longer used.

    @DianQK
    DianQK committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    d047968 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Add crate compiler_builtins to LTO even if the Linkage is `Includ… 

    …edFromDylib`
    @DianQK
    DianQK committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    8d69a1e View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Fix link name for extern "C" in msvc

    @DianQK
    DianQK committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    436d4f6 View commit details
    Browse the repository at this point in the history

  2. Put $(LLVM_BIN_DIR) in quotes to prevent missing backslashes

    @DianQK
    DianQK committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    b9f53be View commit details
    Browse the repository at this point in the history