-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[experiment] -Ztrait-solver=next-coherence
but hacks that make things not fail anymore
#113991
[experiment] -Ztrait-solver=next-coherence
but hacks that make things not fail anymore
#113991
Conversation
@bors try |
⌛ Trying commit e4ce0193dfe3bf8f8480df603e8e23a4ba1868ad with merge eba0caf10bb3b7a1920567f58003d191affe4aac... |
for myself for later: @ craterbot run mode=check-only crates=https://crater-reports.s3.amazonaws.com/pr-113895-1/retry-regressed-list.txt |
This comment has been minimized.
This comment has been minimized.
☀️ Try build successful - checks-actions |
@craterbot run mode=check-only crates=https://crater-reports.s3.amazonaws.com/pr-113895-1/retry-regressed-list.txt |
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🎉 Experiment
|
-Ztrait-solver=next-coherence
but treating inductive cycles as error-Ztrait-solver=next-coherence
but hacks that make things not fail anymore
e4ce019
to
57443cd
Compare
@bors try |
⌛ Trying commit 57443cdd353eeb27dfb4d9955a0c63ae0f3cc63c with merge 92ba2ff79d7a80af24d063a439f8271726e607d7... |
This comment has been minimized.
This comment has been minimized.
☀️ Try build successful - checks-actions |
@craterbot run mode=check-only crates=https://crater-reports.s3.amazonaws.com/pr-113895-1/retry-regressed-list.txt |
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🎉 Experiment
|
57443cd
to
d667549
Compare
@bors try |
⌛ Trying commit d667549 with merge 93b7365ab3319a5c4a78362e458267d6348b7ef2... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
☀️ Try build successful - checks-actions |
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🎉 Experiment
|
I think the remainder of the failures are due to rust-lang/trait-system-refactor-initiative#52 |
i am not endorsing this, just checking how many of these failures are due to inductive cycles being treated as "may not apply" 06409c806e58432eb6a4398792e924a693a4a6b0.
also skipping aliases in
assemble_coherence_unknowable_candidates
(let's just try the self type first, 57443cdd353eeb27dfb4d9955a0c63ae0f3cc63c)r? @ghost