Skip to content

Conversation

mdibaiee
Copy link
Contributor

@mdibaiee mdibaiee commented Jul 26, 2023

Now that we have fixed the underlying cause of long type name inconsistencies in #113893, we can remove the remap-path-prefix logic from CI

resolves #113424

@rustbot
Copy link
Collaborator

rustbot commented Jul 26, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 26, 2023
@mdibaiee
Copy link
Contributor Author

r? jyn514

@rustbot rustbot assigned jyn514 and unassigned wesleywiser Jul 26, 2023
@rust-log-analyzer

This comment has been minimized.

Now that we have fixed the underlying cause of long type name
inconsistencies in rust-lang#113893, we can remove the remap-path-prefix logic
from CI
@mdibaiee mdibaiee force-pushed the remove-remap-path-prefix-ci branch from e45778e to 7d773c3 Compare July 26, 2023 09:55
@mdibaiee mdibaiee marked this pull request as ready for review July 26, 2023 10:48
@jyn514
Copy link
Member

jyn514 commented Jul 26, 2023

i am on indefinite vacation, please do not assign me.

r? @wesleywiser

@rustbot rustbot assigned wesleywiser and unassigned jyn514 Jul 26, 2023
@wesleywiser
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 26, 2023

📌 Commit 7d773c3 has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 26, 2023
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#101994 (rand: freebsd update, using getrandom.)
 - rust-lang#113930 (Add Param and Bound ty to SMIR)
 - rust-lang#113942 (Squelch a noisy rustc_expand unittest)
 - rust-lang#113996 (Define CMAKE_SYSTEM_NAME on a cross build targeting DragonFly.)
 - rust-lang#114070 (Add `sym::iter_mut` + `sym::as_mut_ptr` for Clippy)
 - rust-lang#114073 (Remove -Z diagnostic-width)
 - rust-lang#114090 (compiletest: remove ci-specific remap-path-prefix)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a1956e2 into rust-lang:master Jul 26, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 26, 2023
@mdibaiee mdibaiee deleted the remove-remap-path-prefix-ci branch July 27, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"the full type name has been written to disk" causes UI tests to fail

6 participants