Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lots of tiny incremental simplifications of EmitterWriter internals #114104

Merged
merged 11 commits into from
Aug 4, 2023
Merged

Lots of tiny incremental simplifications of EmitterWriter internals #114104

merged 11 commits into from
Aug 4, 2023

Commits on Jul 31, 2023

  1. Replace the many arguments of EmitterWriter::stderr with builder me… 

    …thods
    @oli-obk
    oli-obk committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    29de70d View commit details
    Browse the repository at this point in the history

  2. Use builder pattern instead of lots of arguments for `EmitterWriter::… 

    …new`
    @oli-obk
    oli-obk committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    0e7ec96 View commit details
    Browse the repository at this point in the history

  3. Remove a bool for color in favor of the WriteColor trait wrapping… 

    … colored and uncolored printing
    @oli-obk
    oli-obk committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    51c2215 View commit details
    Browse the repository at this point in the history

  4. Remove an enum variant that can be covered by another

    @oli-obk
    oli-obk committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    339890e View commit details
    Browse the repository at this point in the history

  5. Merge buffered destination into raw destination

    @oli-obk
    oli-obk committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    0007469 View commit details
    Browse the repository at this point in the history

  6. Move WritableDst method onto Style directly

    @oli-obk
    oli-obk committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    1e2167f View commit details
    Browse the repository at this point in the history

  7. Remove a now-redundant single-variant enum

    @oli-obk
    oli-obk committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    826a8ef View commit details
    Browse the repository at this point in the history

  8. Merge all Destination variants

    @oli-obk
    oli-obk committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    10da30f View commit details
    Browse the repository at this point in the history

  9. Turn a single-variant enum into a struct

    @oli-obk
    oli-obk committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    2131eee View commit details
    Browse the repository at this point in the history

  10. Get rid of the thin wrapper type that is Destination and just write… 

    … to the `Writer` trait object directly
    @oli-obk
    oli-obk committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    d9deaf4 View commit details
    Browse the repository at this point in the history

  11. Sanity check that we actually flush all buffers

    @oli-obk
    oli-obk committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    375d8f1 View commit details
    Browse the repository at this point in the history