Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always add LC_BUILD_VERSION for metadata object files #114114

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Always add LC_BUILD_VERSION for metadata object files #114114

merged 3 commits into from
Aug 29, 2023

Commits on Aug 21, 2023

  1. Always add LC_BUILD_VERSION for metadata object files 

    As of Xcode 15 Apple's linker has become a bit more strict about the
warnings it produces. One of those new warnings requires all valid
Mach-O object files in an archive to have a LC_BUILD_VERSION load
command:

```
ld: warning: no platform load command found in 'ARCHIVE[arm64][2106](lib.rmeta)', assuming: iOS-simulator
```

This was already being done for Mac Catalyst so this change expands this
logic to include it for all Apple platforms. I filed this behavior
change as FB12546320 and was told it was the new intentional behavior.
    @keith
    keith committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    d37fdc9 View commit details
    Browse the repository at this point in the history

  2. Use target.abi instead of string matching llvm_target

    @keith
    keith committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    f988cbb View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Add comment about unused sdk versions

    @keith
    keith committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    2939e85 View commit details
    Browse the repository at this point in the history