Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dist-various linux-gnu target baselines #114189

Closed
wants to merge 1 commit into from

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Jul 28, 2023

These Tier 2 non-host targets were affected by the update to
ubuntu:22.04 in #113931, but the platform support page was already out
of date after #81521 updated to ubuntu:20.04. They are now listed for
kernel 5.15 and glibc 2.35 as found in 22.04, and a new footnote
mentions that this only matters when using the dynamic libstd.so.

r? @Mark-Simulacrum

These Tier 2 non-host targets were affected by the update to
`ubuntu:22.04` in rust-lang#113931, but the platform support page was already out
of date after rust-lang#81521 updated to `ubuntu:20.04`. They are now listed for
kernel 5.15 and glibc 2.35 as found in 22.04, and a new footnote
mentions that this only matters when using the dynamic `libstd.so`.
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 28, 2023
@nikic
Copy link
Contributor

nikic commented Jul 29, 2023

Hm, does the kernel of the host matter for libstd.so? Aren't kernel differences handled at runtime? I'd expect the kernel requirement to always be the lowest overall supported version (apart from target specific requirements, e.g. for newer arches).

@Mark-Simulacrum
Copy link
Member

Yeah, I'd also expect similar. Kernel 5.15 is comparatively very recent -- I'd be surprised if we actually relied on that version here.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2023
@bors
Copy link
Contributor

bors commented Oct 3, 2023

☔ The latest upstream changes (presumably #116372) made this pull request unmergeable. Please resolve the merge conflicts.

@oskgo
Copy link
Contributor

oskgo commented Aug 9, 2024

@cuviper Any updates on this? Thanks

@cuviper
Copy link
Member Author

cuviper commented Aug 21, 2024

I don't have any update, but your ping has bubbled this back up my to-do list, so I'll try to revisit it soon.

@alex-semenyuk alex-semenyuk added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 22, 2024
@JohnCSimon
Copy link
Member

@cuviper

Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this.
Note: if you are going to continue please open the PR BEFORE you push to it, else you won't be able to reopen - this is a quirk of github.
Thanks for your contribution.

@rustbot label: +S-inactive

@JohnCSimon JohnCSimon closed this Feb 5, 2025
@rustbot rustbot added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants