Re-add "--help" to rustpkg #11430
Closed
Re-add "--help" to rustpkg #11430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The help options were lost when the argument parsing was moved to its own file. This adds them back and closes #11423
|
This appears to accept the options, but it doesn't look like it ever actually processes the option? If you run |
ghost
closed this
ghost
deleted the
|
Yeah it appears to break rustpkg even further and out of my depth. Sorry for not testing further. Thought it was an easy fix, but I'll let someone else take it and close this. Sorry again =( |
|
No problem! I know that the functionality still exists somewhere to print out all the help info, though. I'd recommend tracking backwards to the commit that shuffled args around and see how it got removed. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 7, 2023
Correctly format `vec!` invocations The [Rust Style Guide](https://doc.rust-lang.org/nightly/style-guide/expressions.html?highlight=vec#array-literals) says that `vec!` should alwys be used with square brackets, not parenthesis. Within the lint documentation, that rule was violated twice. changelog: none
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The help options were lost when the argument parsing was moved to its own file.
I think I followed everything in the contribution instructions, but this is my first pull request, so let me know if I need to change anything or just close it.