-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coverage: Consolidate FFI types into one module #114360
Conversation
Coverage FFI types were historically split across two modules, because some of them were needed by code in `rustc_codegen_ssa`. Now that all of the coverage codegen code has been moved into `rustc_codegen_llvm` (rust-lang#113355), it's possible to move all of the FFI types into a single module, making it easier to see all of them at once.
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
@rustbot label +A-code-coverage |
I chose to move code out of
|
@bors r+ rollup |
☀️ Test successful - checks-actions |
Finished benchmarking commit (5cbfee5): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 650.605s -> 648.769s (-0.28%) |
Coverage FFI types were historically split across two modules, because some of them were needed by code in
rustc_codegen_ssa
.Now that all of the coverage codegen code has been moved into
rustc_codegen_llvm
(#113355), it's possible to move all of the FFI types into a single module, making it easier to see all of them at once.This PR only moves code and adjusts imports; there should be no functional changes.