-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Steal MIR for CTFE when possible. #114502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit 3e01572c4e541200d43f848893f591714bfa3656 with merge b8b2be5074b7b3846f46bb9c363baa66d7685448... |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (b8b2be5074b7b3846f46bb9c363baa66d7685448): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 650.338s -> 649.841s (-0.08%) |
instr-count is balanced, while cycle count and max-rss appear greener. |
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
and the incremental compilation benchmarks have been quite noisy on bitmaps yesterday/today |
☀️ Test successful - checks-actions |
Finished benchmarking commit (f362387): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 651.433s -> 650.04s (-0.21%) |
Some bodies, like constants, have CTFE MIR but no optimized MIR.
In that case, have
mir_for_ctfe
steal the MIR instead of cloning it.