Migrate a trait selection error to use diagnostic translation #114548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @spastorino (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
matthiaskrgr
reviewed
Aug 6, 2023
This comment has been minimized.
This comment has been minimized.
fee1-dead
force-pushed
the
migrate-to-trans
branch
from
0da9c1b
to
1ca4bc9
Compare
spastorino
approved these changes
Aug 7, 2023
|
Looks good to me but I don't know the diagnostics infrastructure enough to have great judgement. cc @davidtwco |
davidtwco
approved these changes
Aug 8, 2023
|
@bors r+ |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Aug 8, 2023
…, r=davidtwco Migrate a trait selection error to use diagnostic translation
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 9, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#113939 (open pidfd in child process and send to the parent via SOCK_SEQPACKET+CMSG) - rust-lang#114548 (Migrate a trait selection error to use diagnostic translation) - rust-lang#114606 (fix: not insert missing lifetime for `ConstParamTy`) - rust-lang#114634 (Mention riscv64-linux-android support in Android documentation) - rust-lang#114638 (Remove old RPITIT tests (revisions were removed)) - rust-lang#114641 (Rename copying `ascii::Char` methods from `as_` to `to_`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.