CI: do not hide error logs in a group #114573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
This comment has been minimized.
This comment has been minimized.
|
Looks like with this change, the error is now clearly visible in the CI log 🎉 (I'll leave the commit with the error here for now so that others can look at the CI log). |
|
yay @bors delegate+ r=me with the test commit removed |
Kobzol
force-pushed
the
ci-no-group-on-error
branch
from
50450d9 to
8d33608
Compare
bors
added
S-waiting-on-bors
I was wondering about that XD oops |
Both work, the @ version allows to have autocomplete, and (maybe?) reduces chances of typos. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 7, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#113568 (Fix spurious test failure with `panic=abort`) - rust-lang#114196 (Bubble up nested goals from equation in `predicates_for_object_candidate`) - rust-lang#114485 (Add trait decls to SMIR) - rust-lang#114495 (Set max_atomic_width for AVR to 16) - rust-lang#114496 (Set max_atomic_width for sparc-unknown-linux-gnu to 32) - rust-lang#114510 (llvm-wrapper: adapt for LLVM API changes) - rust-lang#114562 (stabilize abi_thiscall) - rust-lang#114570 ([miri][typo] Fix a typo in a vector_block comment.) - rust-lang#114573 (CI: do not hide error logs in a group) r? `@ghost` `@rustbot` modify labels: rollup
It actually works with (I tend to type it with the |
falcucci
added a commit
to falcucci/changelog-it
that referenced
this pull request
Aug 7, 2023
adds the list of contributors to the template. the contributors are: enselic, ralfjung, trolldemorted, matthiaskrgr, ttsugriy, kobzol, and lnicola. this commit updates `example.md` by adding the contributors to the list. the changes can be seen in the diff: ```diff diff --git a/templates/example.md b/templates/example.md index a128037..da0ecc8 100644 --- a/templates/example.md +++ b/templates/example.md @@ -10,3 +10,16 @@ - [ci: do not hide error logs in a group](rust-lang/rust#114573) - [:arrow_up: `rust-analyzer`](rust-lang/rust#114576) - [rollup of 9 pull requests](rust-lang/rust#114585) + +### contributors + +- [enselic](https://github.com/enselic) +- [enselic](https://github.com/enselic) +- [ralfjung](https://github.com/ralfjung) +- [trolldemorted](https://github.com/trolldemorted) +- [matthiaskrgr](https://github.com/matthiaskrgr) +- [matthiaskrgr](https://github.com/matthiaskrgr) +- [ttsugriy](https://github.com/ttsugriy) +- [kobzol](https://github.com/kobzol) +- [lnicola](https://github.com/lnicola) +- [matthiaskrgr](https://github.com/matthiaskrgr) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids creating a GHA group at the very end of a CI workflow when some failure has happened. Before, when a failure has happened, its GHA group was not closed, however the clock drift check function would create a new group, which would actually close the group containing the error log, thus making errors hidden by default, which is not ideal.
See discussion here: https://rust-lang.zulipchat.com/#narrow/stream/326414-t-infra.2Fbootstrap/topic/GHA.20groups.20being.20closed.20on.20failures
r? bootstrap