More minor improvements to rope.rs #1146
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dless copies in pattern-matching), plus removing two warnings
|
The copy warnings seem to be an alias analysis bug (see #1144), which it looks like marijn is going to fix. In that light, do you still want to merge this? Pattern matching doesn't copy in general (it aliases), so converting things like |
|
Ah, good to know. In that case, the only actual optimization is in function |
|
OK, thanks. Closing this one. |
bjorn3
added a commit
to bjorn3/rust
that referenced
this pull request
Mar 29, 2021
Fixes rust-lang#1146 by preventing a hang for [(); usize::MAX], which is used in a test of libcore.
coastalwhite
pushed a commit
to coastalwhite/rust
that referenced
this pull request
Aug 5, 2023
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
Properties which are sanity checks needed to be removed from the UI. They are now marked with the property_class "sanity_check" which makes it easy to filter such checks out as the pipeline to add, remove and edit checks based on their property_class has already been setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have gotten rid of a few inefficiencies, two of which led to warnings.