Only resolve target type in try_coerce in new solver

[compiler-errors]

Only needed in new solver, seems to affect perf in old solver.

cc #114604/#114594

[compiler-errors]

@bors try @rust-timer queue

[bors]

⌛ Trying commit b2e95ad62b2f32f13f18feeee6e5799c5b9d9093 with merge 52480ae4b2feca7f8ed2c5b46c0be89884f6f456...

[bors]

☀️ Try build successful - checks-actions
Build commit: 52480ae4b2feca7f8ed2c5b46c0be89884f6f456 (52480ae4b2feca7f8ed2c5b46c0be89884f6f456)

[rust-timer]

Finished benchmarking commit (52480ae4b2feca7f8ed2c5b46c0be89884f6f456): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.8%	[-2.0%, -1.6%]	2
Improvements ✅ (secondary)	-0.9%	[-1.1%, -0.6%]	4
All ❌✅ (primary)	-1.8%	[-2.0%, -1.6%]	2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.9%	[1.7%, 2.1%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.8%	[-3.8%, -3.8%]	1
All ❌✅ (primary)	1.9%	[1.7%, 2.1%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 632.915s -> 631.09s (-0.29%)

[compiler-errors]

r? @lcnr or @lqd

[lqd]

@bors r+

[bors]

📌 Commit 214d78d has been approved by lqd

It is now in the queue for this repository.

[bors]

⌛ Testing commit 214d78d with merge 622d88d1a9468de9f422d7dd9743f13ef96047b9...

[bors]

☀️ Test successful - checks-actions
Approved by: lqd
Pushing 622d88d1a9468de9f422d7dd9743f13ef96047b9 to master...

[bors]

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

[lqd]

@bors retry

[bors]

⌛ Testing commit 214d78d with merge fd16988...

[bors]

☀️ Test successful - checks-actions
Approved by: lqd
Pushing fd16988 to master...

[rust-timer]

Finished benchmarking commit (fd16988): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.0%	[1.0%, 1.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.7%	[-1.8%, -1.6%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.8%	[-1.8%, 1.0%]	3

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 633.758s -> 633.485s (-0.04%)

[pnkfelix]

Visiting for weekly performance triage

• This was specifically added to undo regressions flagged in PR Rollup of 7 pull requests #114604
• it did indeed undo the big changes: e.g. cranelift-codegen-0.82.1 had regressed by {2%, 1.7%}, and this improved it back by {-1.84%, -1.59%}
• likewise cargo-0.60.0 had improved by -0.93%, and this regressed it back by 0.99%. (I.e. we returned to prior status quo.)
• some other effects were not addressed by this PR, but they are all minor.
• marking as triaged.

@rustbot label: +perf-regression-triaged