Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <[[T; N]; M]>::flatten conversion to [T; N * M] #114676

Closed
wants to merge 1 commit into from

Conversation

nvzqz
Copy link
Contributor

@nvzqz nvzqz commented Aug 9, 2023

This adds a method to convert 2-dimensional array to 1-dimension.

@rustbot
Copy link
Collaborator

rustbot commented Aug 9, 2023

r? @m-ou-se

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 9, 2023
@nvzqz
Copy link
Contributor Author

nvzqz commented Aug 9, 2023

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 9, 2023
@nvzqz nvzqz changed the title Add [[T; N]; M]::flatten conversion to [T; N * M] Add <[[T; N]; M]>::flatten conversion to [T; N * M] Aug 9, 2023
@nvzqz nvzqz mentioned this pull request Aug 9, 2023
5 tasks
@@ -164,6 +164,7 @@
#![feature(const_waker)]
#![feature(core_panic)]
#![feature(duration_consts_float)]
#![feature(generic_const_exprs)]
Copy link
Member

@scottmcm scottmcm Aug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

generic_const_exprs is not something we're willing to enable for core at this time, as I understand it, so I'm going to close this.

(I would also like to have a function like this, but we need to figure out more about the const rules before that can happen.)

@scottmcm scottmcm closed this Aug 9, 2023
@nvzqz nvzqz deleted the nvzqz/array_flatten branch August 10, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants