Rollup of 5 pull requests #114688
Rollup of 5 pull requests #114688
Conversation
Signed-off-by: ozkanonur <work@onurozkan.dev>
…m/array/tuple literals unless *all* sub-expressions had side effects. This would easily allow side effects to slip through, and also wrongly label empty literals as having side effects. Add some tests for the last point
Just remove a typo.
…-config, r=clubby789 better error handling for `rust.codegen-backends` on deserialization Fixes rust-lang#109315
…ler-errors Add clubby789 to `users_on_vacation` I'm on holiday until the 30th of August so won't be able to take on reviews until then
…fects, r=compiler-errors `Expr::can_have_side_effects()` is incorrect for struct/enum/array/tuple literals It would return 'false' unless *all* sub-expressions had side effects. This would easily allow side effects to slip through, and also wrongly label empty literals as having side effects. Add some tests for the last point The function is only used for simple lints and error messages, so not a serious bug.
doc (unstable-book): fix a typo Just fix a small typo.
…, r=lcnr Remove redundant calls to `resolve_vars_with_obligations` I've been auditing the calls to `resolve_vars_with_obligations` for the new solver, and have found a few that have no effect on diagnostics. Let's just remove 'em. Also remove a redundant `resolve_vars_with_obligations_and_mutate_fulfillment` call. r? `@lcnr`
rustbot
added
A-meta
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 465f235 with merge e67d0e09ec40844da5d1e5b29582f36e7d5735bf... |
|
☀️ Test successful - checks-actions |
|
👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward |
|
@bors retry |
|
@bors r- |
|
Finished benchmarking commit (e67d0e09ec40844da5d1e5b29582f36e7d5735bf): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 632.664s -> 632.266s (-0.06%) |
|
@bors r- I don't know what's going on here but it sure doesn't seem like this should be in queue and it is. If someone knows better than me, they can put it back in queue. |
bors
added
S-waiting-on-author
Successful merges:
rust.codegen-backendson deserialization #114278 (better error handling forrust.codegen-backendson deserialization)users_on_vacation#114674 (Add clubby789 tousers_on_vacation)Expr::can_have_side_effects()is incorrect for struct/enum/array/tuple literals #114678 (Expr::can_have_side_effects()is incorrect for struct/enum/array/tuple literals)resolve_vars_with_obligations#114684 (Remove redundant calls toresolve_vars_with_obligations)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup