-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TAITs do not constrain generic params #114742
TAITs do not constrain generic params #114742
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me after the nit
681395d
to
5c95e77
Compare
@bors r=aliemjay |
☀️ Test successful - checks-actions |
Finished benchmarking commit (e81522a): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 633.873s -> 632.781s (-0.17%) |
Fixes #108425
Not sure if I should rework those two failing tests. I guess
tests/ui/type-alias-impl-trait/coherence.rs
could just have the type parameter removed from it? IDK whattests/ui/type-alias-impl-trait/coherence_generalization.rs
is even testing, though.r? @aliemjay
cc @lcnr @oli-obk (when he's back from 🌴)