Make .rmeta file in dep-info have correct name (lib prefix)

[Enselic]

Since filename_for_metadata() and
OutputFilenames::path(OutputType::Metadata) had different logic for the name of the metadata file, the .d file contained a file name different from the actual name used. Share the logic to fix the out-of-sync name.

Without this fix, the .d file contained

dash-separated_something-extra.rmeta: dash-separated.rs

instead of

libdash_separated_something-extra.rmeta: dash-separated.rs

which is the name of the file that is actually written by the compiler.

Worth noting: It took me several iterations to get all tests to pass, so I am relatively confident that this PR does not break anything.

Closes #68839

[rustbot]

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

[compiler-errors]

@bors r+

[bors]

📌 Commit 282e67408b5db63bea6f36e062d35fc491c30ea8 has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit 282e67408b5db63bea6f36e062d35fc491c30ea8 with merge d0172f44523c555494946d64fe220fcfa519310d...

[bors]

💔 Test failed - checks-actions

[Enselic]

I'll look into the failure on Windows.

@rustbot author

[Enselic]

Looks like I just have to adjust how TMPDIR is stripped in the test to handle when /c/ is replaced with C:\ under the hood.

The diff from what you already approved is minimal: click here to see diff

@rustbot ready

[compiler-errors]

@bors r+

[bors]

📌 Commit 1e6d41f72fcc55452b2b6b92e39cbee3b90cf917 has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

[Mark-Simulacrum]

@bors treeclosed-

[bors]

⌛ Testing commit 1e6d41f72fcc55452b2b6b92e39cbee3b90cf917 with merge 24b78bb32be9e844f4afcecca7eec88bd880cac9...

[bors]

💔 Test failed - checks-actions

[Enselic]

Apparently GNU sed and Mac/BSD sed have sed -i incompatibilities, so I had to change the test code again. Diff from what you already approved is small and low-risk.

(symbolic:)
@rustbot ready

[Enselic]

@compiler-errors Friendly ping as I'm starting to suspect you might have missed this was ready for re-review with a small diff compared to what you already approved? (See comment above)

[compiler-errors]

@bors r+

[bors]

📌 Commit 04d81ba has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit 04d81ba with merge 8ed1d4a...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 8ed1d4a to master...

[rust-timer]

Finished benchmarking commit (8ed1d4a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.2%	[2.2%, 2.2%]	1
Regressions ❌ (secondary)	3.0%	[2.1%, 3.7%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.2%	[2.2%, 2.2%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 634.734s -> 636.351s (0.25%)
Artifact size: 318.52 MiB -> 318.44 MiB (-0.03%)