Skip to content

update Miri #115095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Aug 22, 2023
Merged

update Miri #115095

merged 18 commits into from
Aug 22, 2023

Conversation

RalfJung
Copy link
Member

r? @ghost

RalfJung and others added 18 commits August 17, 2023 13:48
@RalfJung
tree borrows: more comments in foreign_read transition
f836cfa
@bors
Auto merge of rust-lang#3031 - RalfJung:foreign-read, r=RalfJung
23b9d95 
tree borrows: more comments in foreign_read transition
@RalfJung
pin a version of serde without intransparent unreproducible binary blobs
44fa4cd
@bors
Auto merge of rust-lang#3032 - RalfJung:serde, r=RalfJung,oli-obk
92217bb 
pin a version of serde without intransparent unreproducible binary blobs

Serde is [shipping a binary blob in its derive crate](serde-rs/serde#2538), which is highly unexpected and subverts user trust. To make matters worse, the binary is [not even reproducible](serde-rs/serde#2575), making the crate largely unauditable and relinquishing the security benefits of open-source software. Build times are not nearly painful enough to justify forcing users to trust binary blobs.
Preparing for merge from rustc
c05fb4c
Merge from rustc
f2fb463
fmt
5356aa4
@bors
Auto merge of rust-lang#3033 - rust-lang:rustup-2023-08-21, r=RalfJung
83ca922 
Automatic sync from rustc
@RalfJung
update recommended RA config
5615562
@RalfJung
fix MIRI_AUTO_OPS not having an effect any more
2f6ffa9
@bors
Auto merge of rust-lang#3034 - RalfJung:ra, r=RalfJung
a5ba57e 
update recommended RA config

Looks like rust-analyzer.checkOnSave.overrideCommand got renamed to rust-analyzer.check.overrideCommand.
@RalfJung
bump serde
95fe7ab
@RalfJung
respect CARGO_EXTRA_FLAGS in more places
269cbc2
@bors
Auto merge of rust-lang#3035 - RalfJung:serde, r=RalfJung
57277c3 
bump serde

bump to a version with the binary blob removed

also, respect CARGO_EXTRA_FLAGS in more places
@RalfJung
make sure './miri many-seeds ./miri run' does not re-invoke the auto-ops
6117fa1
@RalfJung
miri-script: start and stop josh automatically
ee1fbd7
@bors
Auto merge of rust-lang#3036 - RalfJung:josh-autostart, r=RalfJung
0c2dde3 
automatically start and stop josh in rustc-pull/push

Let's make use of the fact that this is not a shell script any more. :)
@RalfJung
update lockfile
47ba2a9
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 22, 2023
@rustbot
Copy link
Collaborator

rustbot commented Aug 22, 2023

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

The Miri subtree was changed

cc @rust-lang/miri

@RalfJung
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 22, 2023

📌 Commit 47ba2a9 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2023
@bors
Copy link
Collaborator

bors commented Aug 22, 2023

⌛ Testing commit 47ba2a9 with merge d8c69df...

@bors
Copy link
Collaborator

bors commented Aug 22, 2023

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing d8c69df to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Aug 22, 2023

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing d8c69df to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 22, 2023
@bors bors merged commit d8c69df into rust-lang:master Aug 22, 2023
@rustbot rustbot added this to the 1.74.0 milestone Aug 22, 2023
@bors bors mentioned this pull request Aug 22, 2023
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d8c69df): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.1% [-2.3%, -1.9%] 2
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 634.665s -> 634.844s (0.03%)
Artifact size: 347.05 MiB -> 346.96 MiB (-0.03%)

@RalfJung RalfJung deleted the miri branch August 24, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.
4 participants
@RalfJung @rustbot @bors @rust-timer