-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: re-enable pretty-std-collections on macOS #115128
Conversation
29bac6b
to
cc0fa87
Compare
Nice! Thanks for looking into the lldb behavior change @bors r+ |
📌 Commit cc0fa87bd4df34e0294783460c5537f1d1b371ff has been approved by It is now in the queue for this repository. |
⌛ Testing commit cc0fa87bd4df34e0294783460c5537f1d1b371ff with merge 72dcbc69c9c86e26700420b72ac5aa069801bfdf... |
💔 Test failed - checks-actions |
Newer lldb versions disable printing of persistent results by default, but lots of rustc debuginfo tests rely on these being printed, so re-enable this by defining an alias as suggested by the patch which disabled persistent result printing in lldb. Signed-off-by: David Wood <david@davidtw.co>
Signed-off-by: David Wood <david@davidtw.co>
cc0fa87
to
3bd5dc3
Compare
So I had originally fixed the failures that happened with new lldb versions by aliasing |
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (960a5ed): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 632.565s -> 631.022s (-0.24%) |
Fixes #78665.
I made some small modifications to this test so that it would pass for me locally (though I was only able to test using lldb without built-in Rust support, but that seems to be the mode in which it would fail). I ran it a few hundred times with stage one and stage two to see if I could re-produce the spurious failures that were being reported in #78665 and couldn't. From the discussion in #78665, it seemed like this was related to Xcode versions and could be reproduced locally fairly easily. It's been a couple years since this was disabled so a lot has changed. If this starts failing spuriously again then we can disable it and I can look into that.
r? @wesleywiser (discussed in wg-debugging's triage meeting)